Date: Tue, 31 Jul 2018 13:55:00 +0000 From: =?iso-8859-1?Q?Timo_V=F6lker?= <timo.voelker@fh-muenster.de> To: "freebsd-java@freebsd.org" <freebsd-java@freebsd.org> Subject: SCTP do not work with OpenJDK8 Message-ID: <FD5A4D7B-42E6-4239-80BF-886876AE58DB@fh-muenster.de>
next in thread | raw e-mail | index | archive | help
--Apple-Mail=_6A74CE1A-FAD5-40C8-AC45-C87F2927D650 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hi, I found an issue with SCTP support in OpenJDK8 for FreeBSD. In my = example=20 https://github.com/msvoelker/java-sctp/ it happened that OpenJDK8 calls sendmsg with an buffer address !=3D NULL = and a buffer length of 0, which is an invalid argument for FreeBSD. I = found the code lines in the function = Java_sun_nio_ch_sctp_SctpChannelImpl_send0 of jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c Besides that, I changed two ifdef statements for FreeBSD. I attach my = patch file at the end. If I copy this patch file to the files directory = of the OpenJDK8 port, I'm able to install OpenJDK and to run the example = application. sudo cp patch-jdk-src-solaris-native-sun-nio-ch-sctp-SctpChannelImpl.c = /usr/ports/java/openjdk8/files cd /usr/ports/java/openjdk8 sudo make install I just saw that hwh found this issue already for OpenJDK7. = https://lists.freebsd.org/pipermail/freebsd-java/2010-September/008906.htm= l Thanks, Timo patch-jdk-src-solaris-native-sun-nio-ch-sctp-SctpChannelImpl.c --- jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c.org = 2018-07-26 09:56:49.897172000 +0200 +++ jdk/src/solaris/native/sun/nio/ch/sctp/SctpChannelImpl.c = 2018-07-30 16:13:19.116935000 +0200 @@ -330,11 +330,11 @@ break; case SCTP_ADDR_MADE_PRIM : event =3D = sun_nio_ch_sctp_PeerAddrChange_SCTP_ADDR_MADE_PRIM; -#ifdef __linux__ /* Solaris currently doesn't support = SCTP_ADDR_CONFIRMED */ +#ifndef __solaris__ /* Solaris currently doesn't support = SCTP_ADDR_CONFIRMED */ break; case SCTP_ADDR_CONFIRMED : event =3D = sun_nio_ch_sctp_PeerAddrChange_SCTP_ADDR_CONFIRMED; -#endif /* __linux__ */ +#endif /* __solaris__ */ } =20 addressObj =3D SockAddrToInetSocketAddress(env, (struct = sockaddr*)&spc->spc_aaddr); @@ -445,13 +445,13 @@ } else if (errno =3D=3D EINTR) { return IOS_INTERRUPTED; =20 -#ifdef __linux__ +#ifndef __solaris__ } else if (errno =3D=3D ENOTCONN) { /* ENOTCONN when EOF reached */ rv =3D 0; /* there will be no control data */ msg->msg_controllen =3D 0; -#endif /* __linux__ */ +#endif /* __solaris__ */ =20 } else { handleSocketError(env, errno); @@ -568,7 +568,7 @@ /* Set up the msghdr structure for sending */ memset(msg, 0, sizeof (*msg)); memset(cbuf, 0, cbuf_size); - msg->msg_name =3D &sa; + msg->msg_name =3D (sa_len =3D=3D 0 ? NULL : &sa); msg->msg_namelen =3D sa_len; iov->iov_base =3D addr; iov->iov_len =3D length;= --Apple-Mail=_6A74CE1A-FAD5-40C8-AC45-C87F2927D650 Content-Disposition: attachment; filename="smime.p7s" Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIQsDCCBRIw ggP6oAMCAQICCQDjC9X4ryXZgTANBgkqhkiG9w0BAQsFADCBgjELMAkGA1UEBhMCREUxKzApBgNV BAoMIlQtU3lzdGVtcyBFbnRlcnByaXNlIFNlcnZpY2VzIEdtYkgxHzAdBgNVBAsMFlQtU3lzdGVt cyBUcnVzdCBDZW50ZXIxJTAjBgNVBAMMHFQtVGVsZVNlYyBHbG9iYWxSb290IENsYXNzIDIwHhcN MTYwMjIyMTMzODIyWhcNMzEwMjIyMjM1OTU5WjCBlTELMAkGA1UEBhMCREUxRTBDBgNVBAoTPFZl cmVpbiB6dXIgRm9lcmRlcnVuZyBlaW5lcyBEZXV0c2NoZW4gRm9yc2NodW5nc25ldHplcyBlLiBW LjEQMA4GA1UECxMHREZOLVBLSTEtMCsGA1UEAxMkREZOLVZlcmVpbiBDZXJ0aWZpY2F0aW9uIEF1 dGhvcml0eSAyMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAy2DX/2ahQc3S+oeXinOr mU3qZzlaoWCARxVOjJWy5c/O01dLjc74VmwVVXYH6kb9yANFYz5w1KtUgLEjnL43KKkJ/wVdGA/E mJk3syD2ZngXh8KdDsxKMucWna4OjSl5BwAgVNwVX0qW13i2NNPBdLWd6b/Ad03qvVkH4FovbDyl ANw1vWUNj38ybfJaaktiAe6sODRZRTZJBdp4ymptW8CBaxHM0jyoi/hxGso74oDdFrRneos26k6R KT2zUVytqAy+nTTj0Q0Xg3XEOR6wlAsS8dVpjiX0uD0rv8COwx47pb9VEKsqrheXXjPOyPP0CQfj AoYxRmsBxRAMEcdZ6QIDAQABo4IBdDCCAXAwDgYDVR0PAQH/BAQDAgEGMB0GA1UdDgQWBBST49gy JtrV8UqlkUrg6kviogzP4TAfBgNVHSMEGDAWgBS/WSA2AHmgoCJrjNXyYdK4LMuCSjASBgNVHRMB Af8ECDAGAQH/AgECMDMGA1UdIAQsMCowDwYNKwYBBAGBrSGCLAEBBDANBgsrBgEEAYGtIYIsHjAI BgZngQwBAgIwTAYDVR0fBEUwQzBBoD+gPYY7aHR0cDovL3BraTAzMzYudGVsZXNlYy5kZS9ybC9U ZWxlU2VjX0dsb2JhbFJvb3RfQ2xhc3NfMi5jcmwwgYYGCCsGAQUFBwEBBHoweDAsBggrBgEFBQcw AYYgaHR0cDovL29jc3AwMzM2LnRlbGVzZWMuZGUvb2NzcHIwSAYIKwYBBQUHMAKGPGh0dHA6Ly9w a2kwMzM2LnRlbGVzZWMuZGUvY3J0L1RlbGVTZWNfR2xvYmFsUm9vdF9DbGFzc18yLmNlcjANBgkq hkiG9w0BAQsFAAOCAQEAhwv/PgKbZchWLdY7mpiLcU/auimqIflGLvWypA+uETh5OLMOdLp2XZ7o GIKWYttMM+jd+WrfMr0sTEdgVX/ndGu0LIPYeWu2t01QC2YHte2zl63q7n8w5pn9IuJyTT6EW+75 z5nqf9dSOS6smABEfmk7v3Xu0As7Gs3l9w8ibEeE9qVHoP3QGjR9rdI9d7Pu9NdN/8Po5ZJPWT6Q RxBKsIVYwG9/+K7tCEKeHtTfFC5Nj7yelMPn7fYY+DxJ5yaopzbYLN4izYuC2Nl44lUSozuHRLYR C9UMUq9pjA8G39CiU4tXmHvP/Qck9Py9w/1KkgKXG/K3ts9lihqitXIZOTCCBawwggSUoAMCAQIC BxtjutAeLD0wDQYJKoZIhvcNAQELBQAwgZUxCzAJBgNVBAYTAkRFMUUwQwYDVQQKEzxWZXJlaW4g enVyIEZvZXJkZXJ1bmcgZWluZXMgRGV1dHNjaGVuIEZvcnNjaHVuZ3NuZXR6ZXMgZS4gVi4xEDAO BgNVBAsTB0RGTi1QS0kxLTArBgNVBAMTJERGTi1WZXJlaW4gQ2VydGlmaWNhdGlvbiBBdXRob3Jp dHkgMjAeFw0xNjA1MjQxMTM4NDBaFw0zMTAyMjIyMzU5NTlaMIGNMQswCQYDVQQGEwJERTFFMEMG A1UECgw8VmVyZWluIHp1ciBGb2VyZGVydW5nIGVpbmVzIERldXRzY2hlbiBGb3JzY2h1bmdzbmV0 emVzIGUuIFYuMRAwDgYDVQQLDAdERk4tUEtJMSUwIwYDVQQDDBxERk4tVmVyZWluIEdsb2JhbCBJ c3N1aW5nIENBMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEAnTt5HEfeH4bLxmnXEJ45 19miMNtyHAV/KV9LaPGtGdZM4WsbsQt/oavge4uL2C3Obog6EO5X5R5/BFE267pwbWOgvpYuQOHR g0xmPRxkaeWbpK1yrmg5UYd5zBfTri9dY3FLOXrrQqeXkGkFv5D/pEBwvQPnv54YiB+fmYhNDkeN SF9lmRDS2SpJ7cG5LR2fEssV0z9/HlQvOq6TV6d+eMrVSuIa5e1BfVNfyLMq9YowrO0XBSQ/tqAL B/1NGpoDUqA2nN4kh2Xk5/rHlnMkFM3Q6BtonhhZrnZ+99EKeDyHS7A3z1PKOjgQ88tHbYxkPTxa RUq6yoB8uPPnp0xMzQIDAQABo4ICBTCCAgEwEgYDVR0TAQH/BAgwBgEB/wIBATAOBgNVHQ8BAf8E BAMCAQYwKQYDVR0gBCIwIDANBgsrBgEEAYGtIYIsHjAPBg0rBgEEAYGtIYIsAQEEMB0GA1UdDgQW BBRrOpiL+fJTidrgrbIyHgkf6Ko7dDAfBgNVHSMEGDAWgBST49gyJtrV8UqlkUrg6kviogzP4TCB jwYDVR0fBIGHMIGEMECgPqA8hjpodHRwOi8vY2RwMS5wY2EuZGZuLmRlL2dsb2JhbC1yb290LWcy LWNhL3B1Yi9jcmwvY2FjcmwuY3JsMECgPqA8hjpodHRwOi8vY2RwMi5wY2EuZGZuLmRlL2dsb2Jh bC1yb290LWcyLWNhL3B1Yi9jcmwvY2FjcmwuY3JsMIHdBggrBgEFBQcBAQSB0DCBzTAzBggrBgEF BQcwAYYnaHR0cDovL29jc3AucGNhLmRmbi5kZS9PQ1NQLVNlcnZlci9PQ1NQMEoGCCsGAQUFBzAC hj5odHRwOi8vY2RwMS5wY2EuZGZuLmRlL2dsb2JhbC1yb290LWcyLWNhL3B1Yi9jYWNlcnQvY2Fj ZXJ0LmNydDBKBggrBgEFBQcwAoY+aHR0cDovL2NkcDIucGNhLmRmbi5kZS9nbG9iYWwtcm9vdC1n Mi1jYS9wdWIvY2FjZXJ0L2NhY2VydC5jcnQwDQYJKoZIhvcNAQELBQADggEBAIF4RaROpH8OVfAJ sWo+eMxoNakc85WeP/P432s4d4ksjbWtPsfylM2gBq66zKixrTMItiSGYjZMeG5Q8NVuYI1PUjFD l0Z18GLkbmZRwUIxZ1DlSec5HsufyoZI3ggU/xVLK2aboDifAM79p+vRf1ctyExf3BARlz6WBAJc hKgpOWyU/BCSBnue7thGtBu1Aww42dywqT9xBguyAwczwo1IYyUlPHp7V273igU477igri/02wfV W4QYwam4S85skBqC5Lk9+nfx0h8zAr9T53b53CYlQW8vphv6pBOQ+nx+2QtgXey/ykGgYfsRSSnY qC11FdhKGOoW71U0IhoTjQYwggXmMIIEzqADAgECAgwdgtH8FJ0VCMZ26e4wDQYJKoZIhvcNAQEL BQAwgY0xCzAJBgNVBAYTAkRFMUUwQwYDVQQKDDxWZXJlaW4genVyIEZvZXJkZXJ1bmcgZWluZXMg RGV1dHNjaGVuIEZvcnNjaHVuZ3NuZXR6ZXMgZS4gVi4xEDAOBgNVBAsMB0RGTi1QS0kxJTAjBgNV BAMMHERGTi1WZXJlaW4gR2xvYmFsIElzc3VpbmcgQ0EwHhcNMTcwNzEwMTAxODIwWhcNMjAwNzA5 MTAxODIwWjB6MQswCQYDVQQGEwJERTEgMB4GA1UECgwXRmFjaGhvY2hzY2h1bGUgTXVlbnN0ZXIx MjAwBgNVBAsMKUZhY2hiZXJlaWNoIEVsZWt0cm90ZWNobmlrIHVuZCBJbmZvcm1hdGlrMRUwEwYD VQQDDAxUaW1vIFZvZWxrZXIwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIBAQC/gQYu/Hjb 3078pLzYaFpcgo/JHZHLjOLe85YFMr056WFSN/Jwdh1Asny4ZKcLzHd7vMjr3fjg8Sgo04y+lBI4 8O5FJTgixYB1oV9DU5GlWcC/6eLhpIPNraOcK4KJVlwqw7uc1L8fbyjCMrTNtYHFEy23B9NFgxbS pxhQ6FCgS6kjziTgFL6s072+j6MMJi1RdZZUNZGq52gCyIKNAxMt2b42/Kk7PTWYCSA8HzxrLsQe YxmxoxLoGTlnZxuC8WKU+1V1pUiS+Ns3krHHBHIeeogR/JeILBX0OheqStUnnEABcsWj+4uGYxvP RdZXBXm8wKjcRcnJDrKizS4G6j27AgMBAAGjggJWMIICUjBABgNVHSAEOTA3MBEGDysGAQQBga0h giwBAQQDBTARBg8rBgEEAYGtIYIsAgEEAwEwDwYNKwYBBAGBrSGCLAEBBDAJBgNVHRMEAjAAMA4G A1UdDwEB/wQEAwIF4DAdBgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwHQYDVR0OBBYEFOOJ r1RvTOvocygvlHm6xGfZS5dNMB8GA1UdIwQYMBaAFGs6mIv58lOJ2uCtsjIeCR/oqjt0MCYGA1Ud EQQfMB2BG3RpbW8udm9lbGtlckBmaC1tdWVuc3Rlci5kZTCBjQYDVR0fBIGFMIGCMD+gPaA7hjlo dHRwOi8vY2RwMS5wY2EuZGZuLmRlL2Rmbi1jYS1nbG9iYWwtZzIvcHViL2NybC9jYWNybC5jcmww P6A9oDuGOWh0dHA6Ly9jZHAyLnBjYS5kZm4uZGUvZGZuLWNhLWdsb2JhbC1nMi9wdWIvY3JsL2Nh Y3JsLmNybDCB2wYIKwYBBQUHAQEEgc4wgcswMwYIKwYBBQUHMAGGJ2h0dHA6Ly9vY3NwLnBjYS5k Zm4uZGUvT0NTUC1TZXJ2ZXIvT0NTUDBJBggrBgEFBQcwAoY9aHR0cDovL2NkcDEucGNhLmRmbi5k ZS9kZm4tY2EtZ2xvYmFsLWcyL3B1Yi9jYWNlcnQvY2FjZXJ0LmNydDBJBggrBgEFBQcwAoY9aHR0 cDovL2NkcDIucGNhLmRmbi5kZS9kZm4tY2EtZ2xvYmFsLWcyL3B1Yi9jYWNlcnQvY2FjZXJ0LmNy dDANBgkqhkiG9w0BAQsFAAOCAQEAGEYW34tG4ACeQk3vN6TBr9HRRE4Rc3tJoh5odaAx4UDnO6B7 EsTOSyZmJ5jdY6ui8ns9jiwwv6yZsuhopqSatS06aSlXoJ7GWBeTS9FbDu4Fa3+Hmfo+UiqG0cul MLOfKasuZx8bsoOq1kR7WdABUL3m7FuLhIVEeuJ39yQSiWxwJ4jZ5Cx0evaXIcGDIXOE9e+GcXz2 mm1yfFxITLHt5q37phfTDLH4IOgWt9GORlDBoatSu56QwfRGwhVYmkTRrUFss3QuQ/z3SwOt30Lj MNdVk6OkQBNj9QBH5PSH/Ok/JIQODVotZWG7HQ8/8nyzYTH0ccW/1HIrCwvKicZJcTGCA40wggOJ AgEBMIGeMIGNMQswCQYDVQQGEwJERTFFMEMGA1UECgw8VmVyZWluIHp1ciBGb2VyZGVydW5nIGVp bmVzIERldXRzY2hlbiBGb3JzY2h1bmdzbmV0emVzIGUuIFYuMRAwDgYDVQQLDAdERk4tUEtJMSUw IwYDVQQDDBxERk4tVmVyZWluIEdsb2JhbCBJc3N1aW5nIENBAgwdgtH8FJ0VCMZ26e4wCQYFKw4D AhoFAKCCAcMwGAYJKoZIhvcNAQkDMQsGCSqGSIb3DQEHATAcBgkqhkiG9w0BCQUxDxcNMTgwNzMx MTM1NTAwWjAjBgkqhkiG9w0BCQQxFgQUZ35JRup1LpV/NVgNPH7rhHrkI90wga8GCSsGAQQBgjcQ BDGBoTCBnjCBjTELMAkGA1UEBhMCREUxRTBDBgNVBAoMPFZlcmVpbiB6dXIgRm9lcmRlcnVuZyBl aW5lcyBEZXV0c2NoZW4gRm9yc2NodW5nc25ldHplcyBlLiBWLjEQMA4GA1UECwwHREZOLVBLSTEl MCMGA1UEAwwcREZOLVZlcmVpbiBHbG9iYWwgSXNzdWluZyBDQQIMHYLR/BSdFQjGdunuMIGxBgsq hkiG9w0BCRACCzGBoaCBnjCBjTELMAkGA1UEBhMCREUxRTBDBgNVBAoMPFZlcmVpbiB6dXIgRm9l cmRlcnVuZyBlaW5lcyBEZXV0c2NoZW4gRm9yc2NodW5nc25ldHplcyBlLiBWLjEQMA4GA1UECwwH REZOLVBLSTElMCMGA1UEAwwcREZOLVZlcmVpbiBHbG9iYWwgSXNzdWluZyBDQQIMHYLR/BSdFQjG dunuMA0GCSqGSIb3DQEBAQUABIIBABWrzDQoZgQCbcfHl1V8PoaQ7F3sOj3HR7YV6ME1UYDYyUdv 7BHq0YBKKSZvumlrmsDjUFw29JCsBuYog1IuyPrzybRf42ZmXQjD/JGD80XCrkOwkL9Dsne1xzqn lS7Lsqshd+Bheq4561P7+eo3QVavAuK9C2cBnkgFS4ZSvu4eOk4hKC3b+Aj+Gt6hYK0m2rBFjp6d 1i5GEspg7KSA24JUbYJIF4j01J6aulvmHM8unXIr8cK2Yie3+nfg/BfXQO1K3YfeJN5DHvUknigY hChMxUDqRdn/vnl7OjJuuPsZqmgZYJuLSXAnN+XhjaHodo99B+jJ6mUirdceE1OGMXIAAAAAAAA= --Apple-Mail=_6A74CE1A-FAD5-40C8-AC45-C87F2927D650--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?FD5A4D7B-42E6-4239-80BF-886876AE58DB>