Date: Mon, 4 Jul 2005 10:31:46 +0900 From: Pyun YongHyeon <pyunyh@gmail.com> To: Andrew Thompson <thompsa@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Mike Silbersack <silby@silby.com>, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net bridge.c Message-ID: <20050704013146.GB896@rndsoft.co.kr> In-Reply-To: <20050703235733.GA8138@heff.fud.org.nz> References: <200507031824.j63IO3Bs009536@repoman.freebsd.org> <20050703184013.U21939@odysseus.silby.com> <20050703235733.GA8138@heff.fud.org.nz>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 04, 2005 at 11:57:33AM +1200, Andrew Thompson wrote: > On Sun, Jul 03, 2005 at 06:41:36PM -0500, Mike Silbersack wrote: > > [...] > > > > What's the route that a packet takes before it gets to the bridge? If it > > goes through ether_input, it would make sense to put the alignment there > > when necessary. > > Both bridges tap their packets off near the end of ether_input(). Since > we only need to check alignment when using pfil(9) and each bridge has > its own knobs to control filtering, it seems best to leave it where it > is at the moment. > No, all protocol handlers should check alignment too. Normal code path without bridge/if_bridge would suffer from unaligned access. But I think your patch wouldn't hurt existing code. :-) -- Regards, Pyun YongHyeon
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050704013146.GB896>