Date: Tue, 2 Apr 2019 12:49:31 -0600 From: Alan Somers <asomers@freebsd.org> To: Enji Cooper <yaneurabeya@gmail.com> Cc: src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org Subject: Re: svn commit: r345809 - projects/fuse2/tests/sys/fs/fusefs Message-ID: <CAOtMX2inJJk8Hr-TUpUzX3L=afufiq2oFfdZ8i4H8CvVUveFyw@mail.gmail.com> In-Reply-To: <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com> References: <201904021844.x32Ii1wR041319@repo.freebsd.org> <77D06D49-8CE8-483C-90FF-D8CD0122599E@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 2, 2019 at 12:45 PM Enji Cooper <yaneurabeya@gmail.com> wrote: > > > > On Apr 2, 2019, at 11:44 AM, Alan Somers <asomers@FreeBSD.org> wrote: > > > > Author: asomers > > Date: Tue Apr 2 18:44:01 2019 > > New Revision: 345809 > > URL: https://svnweb.freebsd.org/changeset/base/345809 > > > > Log: > > fusefs: check return value of wait(2) in fork tests > > > > Reported by: ngie > > Sponsored by: The FreeBSD Foundation > > > > Modified: > > projects/fuse2/tests/sys/fs/fusefs/utils.cc > > > > Modified: projects/fuse2/tests/sys/fs/fusefs/utils.cc > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:09:= 40 2019 (r345808) > > +++ projects/fuse2/tests/sys/fs/fusefs/utils.cc Tue Apr 2 18:44:= 01 2019 (r345809) > > @@ -321,7 +321,7 @@ out: > > /* Signal the child process to go */ > > ASSERT_EQ(0, sem_post(sem)) << strerror(errno); > > > > - wait(&child_status); > > + ASSERT_LE(0, wait(&child_status)) << strerror(errno); > > Don=E2=80=99t you want ASSERT_GE here, since you=E2=80=99re testing that = wait succeeded? > -Enji Opposite operand order. I'm asserting that 0 is less than or equal to wait's return value. -Alan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2inJJk8Hr-TUpUzX3L=afufiq2oFfdZ8i4H8CvVUveFyw>