Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 24 Aug 2019 15:19:24 +0200
From:      Piotr Kubaj <pkubaj@anongoth.pl>
To:        Jan Beich <jbeich@freebsd.org>
Cc:        Piotr Kubaj <pkubaj@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r509720 - in head/lang/angelscript: . files
Message-ID:  <20190824131924.GC79088@KGPE-D16>
In-Reply-To: <k1b2-u2wa-wny@FreeBSD.org>
References:  <201908241238.x7OCcuT1025093@repo.freebsd.org> <k1b2-u2wa-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--JgQwtEuHJzHdouWu
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

AS_BIG_ENDIAN indeed seems unnecessary, I will remove it, but powerpc64 on =
FreeBSD is only big-endian, there's no little-endian variant.

On 19-08-24 15:08:37, Jan Beich wrote:
> Piotr Kubaj <pkubaj@FreeBSD.org> writes:
>=20
> > Added: head/lang/angelscript/files/patch-as_config.h
> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
> >
> > --- /dev/null	00:00:00 1970	(empty, because file is newly added)
> > +++ head/lang/angelscript/files/patch-as_config.h	Sat Aug 24 12:38:55 2=
019	(r509720)
> > @@ -0,0 +1,12 @@
> > +--- ../../source/as_config.h.orig	2019-07-28 15:58:25.283690000 +0200
> > ++++ ../../source/as_config.h	2019-07-28 16:08:34.592212000 +0200
> > +@@ -953,6 +953,9 @@
> > + 			#define COMPLEX_RETURN_MASK (asOBJ_APP_CLASS_DESTRUCTOR | asOBJ_AP=
P_CLASS_COPY_CONSTRUCTOR | asOBJ_APP_ARRAY)
> > + 			#define THISCALL_PASS_OBJECT_POINTER_ON_THE_STACK
> > + 			#define AS_X86
> > ++		#elif defined(__powerpc64__)
> > ++			#define AS_BIG_ENDIAN
> > ++			#define AS_MAX_PORTABILITY
>=20
> __powerpc64__ includes both big- and little- endian variants.
> AS_BIG_ENDIAN is already defined conditionally in as_config.h:
>=20
>   #if !defined(AS_BIG_ENDIAN) && \
>           defined(__BYTE_ORDER) && __BYTE_ORDER =3D=3D __BIG_ENDIAN || \
>           defined(__BIG_ENDIAN__) || \
>           defined(__ARMEB__) || \
>           defined(__THUMBEB__) || \
>           defined(__AARCH64EB__) || \
>           defined(_MIBSEB) || defined(__MIBSEB) || defined(__MIBSEB__)
>                   #define AS_BIG_ENDIAN
>   #endif
>=20
> $ clang -target powerpc64le-unknown-freebsd12.0 -dM -E -</dev/null | grep=
 -i -e __p.\*pc -e endian
> #define _LITTLE_ENDIAN 1
> #define __BYTE_ORDER__ __ORDER_LITTLE_ENDIAN__
> #define __LITTLE_ENDIAN__ 1
> #define __ORDER_BIG_ENDIAN__ 4321
> #define __ORDER_LITTLE_ENDIAN__ 1234
> #define __ORDER_PDP_ENDIAN__ 3412
> #define __POWERPC__ 1
> #define __PPC64__ 1
> #define __PPC__ 1
> #define __powerpc64__ 1
> #define __powerpc__ 1
> #define __ppc64__ 1
> #define __ppc__ 1
>=20
> $ clang -target powerpc64-unknown-freebsd12.0 -dM -E -</dev/null | fgrep =
-i endian
> #define _BIG_ENDIAN 1
> #define __BIG_ENDIAN__ 1
> #define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__
> #define __ORDER_BIG_ENDIAN__ 4321
> #define __ORDER_LITTLE_ENDIAN__ 1234
> #define __ORDER_PDP_ENDIAN__ 3412
>=20
> $ ssh ref12-ppc64.freebsd.org
> $ gcc8 -dM -E -</dev/null | fgrep -i endian
> #define __ORDER_LITTLE_ENDIAN__ 1234
> #define __BIG_ENDIAN__ 1
> #define __FLOAT_WORD_ORDER__ __ORDER_BIG_ENDIAN__
> #define __ORDER_PDP_ENDIAN__ 3412
> #define _BIG_ENDIAN 1
> #define __ORDER_BIG_ENDIAN__ 4321
> #define __VEC_ELEMENT_REG_ORDER__ __ORDER_BIG_ENDIAN__
> #define __BYTE_ORDER__ __ORDER_BIG_ENDIAN__

--JgQwtEuHJzHdouWu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl1hOVwACgkQelmbhSCD
nJ1REQ//XNBNxrsVxZxW9otgOpzwJ7x7hqgkYE4FDCRxzEj97SU8gqmmukdiO1z3
wAL8tMPK8ZmxRYYJE+nmZW1AsNwPo4PMSctXkwBZ9crVLALjDzhRhyB6zpFqSxbr
U6MU+lRNd52t4L38jkIVK/YPCnJcslkNaUio++yvSR6iec58wy6Qz9chsHOqi+87
QBSBrofiPqzANAoNQ/yguKy6VLnuFYZ8AUOKNgqzhbMGvVuo+aqyrwTLAwI2FtYm
umUbBvs8mZLJPgrC+EoVKtppV63yFzEBxM5kOYRfzkZS1wpPRqGaZKGiaaA2IgV8
Q6e8H0C7XLsbzYWV2xXM7We/pn7R6onYOuF5H1j0bQTS0PPrwUnZJx+rh5RuTav3
Wv5EeX+rpRF6OjmIG6aKsyAigD0gPW9/gUpEdtNlt2oR3T5XrmkyjdJ87Hl7L9eF
MumA+j0DBLbnuolyYRm6MjFHHoLZUnAg/0nmPPfFdy99tdgFgkjQqbZ9CkZl8xZl
ZCJtna5WKZfgJIeBFfShiu6hKhjzpfMiwkYsYXr1poaUoOagxmOg74In5gTU/l1Y
O67uhgix1YEbzb9xMbrvraPkKIeCsaviiKNLxo9gK81gOcAOwuTOsGW6S9fUO07U
Bz/mNWf0CWXAuwt3XxF4/iMX3uRpe/R2S1sdH3T8ronneVG0Xrs=
=9+FZ
-----END PGP SIGNATURE-----

--JgQwtEuHJzHdouWu--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190824131924.GC79088>