Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 21 Jul 2003 15:10:49 -0400 (EDT)
From:      John Baldwin <jhb@FreeBSD.org>
To:        Nate Lawson <njl@FreeBSD.org>
Cc:        cvs-all@FreeBSD.org
Subject:   RE: cvs commit: src/sys/dev/acpica acpi_ec.c
Message-ID:  <XFMail.20030721151049.jhb@FreeBSD.org>
In-Reply-To: <200307202112.h6KLCLiv059614@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

On 20-Jul-2003 Nate Lawson wrote:
> njl         2003/07/20 14:12:21 PDT
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/dev/acpica       acpi_ec.c 
>   Log:
>   Do not call acpi_MatchHid() for all probe cases since it accesses the
>   namespace.  To compensate for it only being used in the !ECDT case, use
>   a more robust approach to indicate a device was probed via ECDT by setting
>   the private ivar to be &acpi_ec_devclass.  Without the acpi_MatchHid() call
>   now, it might have been possible for a non-EC device to have had its magic
>   match our previous flag.
>   
>   Pointed out by:         takawata

Assuming you are doing a device_add_child() to add the ec, you could add it
with the name "acpi_ec" and then only the ec driver would probe it.

-- 

John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve!"  -  http://www.FreeBSD.org/



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20030721151049.jhb>