Date: Thu, 2 Oct 2008 13:05:47 -0400 From: John Baldwin <jhb@freebsd.org> To: Warner Losh <imp@freebsd.org> Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccbb pccbb_pci.c Message-ID: <200810021305.47479.jhb@freebsd.org> In-Reply-To: <200810020629.m926TqZq036159@repoman.freebsd.org> References: <200810020629.m926TqZq036159@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thursday 02 October 2008 02:29:45 am Warner Losh wrote: > imp 2008-10-02 06:29:45 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pccbb pccbb_pci.c > Log: > SVN rev 183539 on 2008-10-02 06:29:45Z by imp > > Don't forget to match on a CLASS of PCIC_BRIDGE as well as subclass > PCIS_BRIDGE_CARDBUS. Otherwise, we may hit a few false positives.... Shouldn't it use BUS_GENERIC_PROBE instead of BUS_DEFAULT_PROBE when matching purely on the class codes? -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200810021305.47479.jhb>