Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 19 Jan 2014 15:15:58 GMT
From:      Jean-Sébastien Pédron <dumbbell@FreeBSD.org>
To:        freebsd-gnats-submit@FreeBSD.org
Subject:   ports/185880: [PATCH] audio/moc: options VORBIS and FLAC not honored when devel/pkgconf isn't installed
Message-ID:  <201401191515.s0JFFwjv075949@oldred.freebsd.org>
Resent-Message-ID: <201401191520.s0JFK0oc012928@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         185880
>Category:       ports
>Synopsis:       [PATCH] audio/moc: options VORBIS and FLAC not honored when devel/pkgconf isn't installed
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Jan 19 15:20:00 UTC 2014
>Closed-Date:
>Last-Modified:
>Originator:     Jean-Sébastien Pédron
>Release:        9.2-STABLE
>Organization:
The FreeBSD Project
>Environment:
FreeBSD magellan.dumbbell.fr 9.2-STABLE FreeBSD 9.2-STABLE #0: Sun Jan 19 02:23:24 CET 2014     root@magellan.dumbbell.fr:/usr/obj/mnt/home/dumbbell/Projects/freebsd/src/SVN/stable/9/sys/GENERIC  amd64
>Description:
When devel/pkgconfig isn't installed, the configure script fails to find libvorbis and libflac but doesn't complain. This leads to a player without Vorbis/FLAC formats support, even if the user selected those options.

The official binary package is affected by this problem.
>How-To-Repeat:

>Fix:
The attached patch fixes it by adding pkgconfig to USES.

Patch attached with submission follows:

Index: audio/moc/Makefile
===================================================================
--- audio/moc/Makefile	(revision 339619)
+++ audio/moc/Makefile	(working copy)
@@ -10,7 +10,7 @@ MASTER_SITES=	ftp://ftp.daper.net/pub/soft/moc/sta
 MAINTAINER=	rzinkov@gmail.com
 COMMENT=	Console audio player designed to be powerful and easy to use
 
-USES=		gmake
+USES=		pkgconfig gmake
 NO_STAGE=	yes
 USE_BZIP2=	yes
 USE_LDCONFIG=	yes


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201401191515.s0JFFwjv075949>