Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 23 Feb 2006 19:11:16 +0000 (UTC)
From:      John Baldwin <jhb@FreeBSD.org>
To:        src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   cvs commit: src/sys/dev/fdc fdc.c
Message-ID:  <200602231911.k1NJBGOV014647@repoman.freebsd.org>

next in thread | raw e-mail | index | archive | help
jhb         2006-02-23 19:11:16 UTC

  FreeBSD src repository

  Modified files:
    sys/dev/fdc          fdc.c 
  Log:
  - Use callout_init_mtx() to initialize toffhandle callout using the fdc's
    mutex.
  - Don't use callout_drain() to stop the toffhandle callout while holding the
    fdc mutex (this could deadlock) in functions called from softclock
    (callouts aren't allowed to do voluntary sleeps).  Instead, use
    callout_stop().  Note that since we hold the associated mutex and are now
    using callout_init_mtx(), callout_stop() is just as effective as
    callout_drain().  (Though callout_drain() is still needed in detach to
    make sure softclock isn't contesting on our mutex before we destroy the
    mutex.)
  - Remove unused callout 'tohandle' from softc.
  
  MFC after:      1 week
  
  Revision  Changes    Path
  1.309     +5 -9      src/sys/dev/fdc/fdc.c



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602231911.k1NJBGOV014647>