Date: Tue, 3 Aug 2021 02:12:01 GMT From: Kevin Bowling <kbowling@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org Subject: git: 2c99e12ff176 - stable/12 - igb: clean up igb_txrx comments Message-ID: <202108030212.1732C1oA064621@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch stable/12 has been updated by kbowling (ports committer): URL: https://cgit.FreeBSD.org/src/commit/?id=2c99e12ff1761ea66fe2ed183e55a7cb60cc0007 commit 2c99e12ff1761ea66fe2ed183e55a7cb60cc0007 Author: Kevin Bowling <kbowling@FreeBSD.org> AuthorDate: 2021-07-31 15:04:25 +0000 Commit: Kevin Bowling <kbowling@FreeBSD.org> CommitDate: 2021-08-03 02:10:52 +0000 igb: clean up igb_txrx comments Reviewed by: grehan MFC after: 3 days Differential Revision: https://reviews.freebsd.org/D31227 (cherry picked from commit ff01d6343f1f0c6550e4072eddda91dabd366d09) --- sys/dev/e1000/igb_txrx.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/sys/dev/e1000/igb_txrx.c b/sys/dev/e1000/igb_txrx.c index 24a80c1857b2..3aa13fe2a1d4 100644 --- a/sys/dev/e1000/igb_txrx.c +++ b/sys/dev/e1000/igb_txrx.c @@ -524,7 +524,6 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype) uint16_t status = (uint16_t)staterr; uint8_t errors = (uint8_t)(staterr >> 24); - /* Ignore Checksum bit is set */ if (__predict_false(status & E1000_RXD_STAT_IXSM)) return; @@ -539,9 +538,7 @@ igb_rx_checksum(uint32_t staterr, if_rxd_info_t ri, uint32_t ptype) /* Valid L4E checksum */ if (__predict_true(status & (E1000_RXD_STAT_TCPCS | E1000_RXD_STAT_UDPCS))) { - /* SCTP header present. - * XXXKB: ETQF doesn't appear to be used in igb? - */ + /* SCTP header present */ if (__predict_false((ptype & E1000_RXDADV_PKTTYPE_ETQF) == 0 && (ptype & E1000_RXDADV_PKTTYPE_SCTP) != 0)) { ri->iri_csum_flags |= CSUM_SCTP_VALID;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202108030212.1732C1oA064621>