Date: Tue, 17 Apr 2018 12:25:41 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332652 - in head/sys: conf dev/puc modules/puc Message-ID: <CANCZdfoxTz5RXQ1cayBK3Gm6UMJcWHVFEOLhK7jrBjA8hpNc1Q@mail.gmail.com> In-Reply-To: <3010482.A3g1Uy1uGA@ralph.baldwin.cx> References: <201804171646.w3HGk9vn040646@repo.freebsd.org> <3010482.A3g1Uy1uGA@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Apr 17, 2018 at 11:20 AM, John Baldwin <jhb@freebsd.org> wrote: > On Tuesday, April 17, 2018 04:46:09 PM Warner Losh wrote: > > Author: imp > > Date: Tue Apr 17 16:46:08 2018 > > New Revision: 332652 > > URL: https://svnweb.freebsd.org/changeset/base/332652 > > > > Log: > > Add PNP info to the PCI attahement of the puc driver. > > > > Adjust sys/conf/files and sys/modules/puc/Makefile to omit > > pucdata.c now tht it's included by puc_pci.c. > > > > Submitted by: Lakhan Shiva Kamireddy (with build fixes by me) > > Pull Request: https://github.com/freebsd/freebsd/pull/136 > > If you are going to #include it you can remove the terminator entry > and use nitems() in puc_pci_match instead. That will also remove the > need for the - 1 hack in the MODULE_PNP_INFO line. > Good suggestion... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfoxTz5RXQ1cayBK3Gm6UMJcWHVFEOLhK7jrBjA8hpNc1Q>