Date: Sun, 2 Jun 2019 22:39:26 +0200 From: Benny Goemans <benny.goemans@gmail.com> To: Gerald Pfeifer <gerald@pfeifer.com>, Steve Wills <swills@FreeBSD.org>, Tobias Kortkamp <tobik@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r502742 - in head/games: . devilutionX devilutionX/files Message-ID: <3802270e-645c-a446-fc6a-bdf70c81fd22@gmail.com> In-Reply-To: <alpine.LSU.2.21.1906022135030.3441@anthias.pfeifer.com> References: <201905261834.x4QIYhE7073602@repo.freebsd.org> <alpine.LSU.2.21.1906022135030.3441@anthias.pfeifer.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2019-06-02 21:38, Gerald Pfeifer wrote: > On Sun, 26 May 2019, Steve Wills wrote: >> Author: swills >> Date: Sun May 26 18:34:42 2019 >> New Revision: 502742 >> URL: https://svnweb.freebsd.org/changeset/ports/502742 >> >> Log: >> games/devilutionX: create port >> >> Open-Source implementation of the Diablo(TM) game engine for X. This port >> requires a file from the original game to work. >> >> WWW: https://github.com/diasurgical/devilutionX > I was going to comment on this after noticing the following > combination... > >> +USES= cmake compiler:c++14-lang dos2unix sdl >> +USE_GCC= yes > ...but it appears Tobias bet me to it with > > r502770 | tobik | 2019-05-27 06:32:24 +0000 (Mo., 27 Mai 2019) > > games/devilutionX: Remove USES=compiler:c++14-lang > > It does not make any sense when also setting USE_GCC=yes. > > Now the question is: does it really have to be GCC (and if so, why)? > > We generally prefer not to depend on a specific compiler make (or > version), and this says the guy who maintains the lang/gcc* ports. ;-) > > Gerald The upstream committer(s) have been looking into compilation on Clang, but hadn't been able to do that on FreeBSD (just yet). They did however manage to do it on MacOS. Should I find some more time to try and tackle this myself, I'll put out another diff to remove GCC use. I'd prefer to use Clang as well. I have however tried this a few times and haven't been able to fix it myself, but I don't know much about GCC and Clang differences. So it'll probably take some time. Regards, Benny
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3802270e-645c-a446-fc6a-bdf70c81fd22>