Date: Sat, 12 Oct 2013 20:09:12 +0100 From: Chris Rees <crees@bayofrum.net> To: Jason Helfman <jgh@freebsd.org>, pgsql@freebsd.org, Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... Message-ID: <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost> In-Reply-To: <CAMHz58SsL9LQP1WYzdR_q2fLYjeOkGMy4nc_QJvXj7K8yxy4AA@mail.gmail.com> References: <201310100009.r9A09Zah023159@svn.freebsd.org> <CAMHz58SsL9LQP1WYzdR_q2fLYjeOkGMy4nc_QJvXj7K8yxy4AA@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Looks fine to me, if Jason approves.
Thanks also for the Python changes.
Chris
-----Original Message-----
From: Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
To: Jason Helfman <jgh@freebsd.org>, pgsql@freebsd.org
Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Sent: Sat, 12 Oct 2013 19:55
Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper...
Hi Jason and pgsql@ team,
May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and
portlint complains [1].
I have prepared a patch [2] which contains 2 changes:
1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT}
2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports
I have also checked PKGNAME is unchanged after applying this patch.
Please review it.
Thanks.
[1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section.
[2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch
Regards,
sunpoet
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
--
This message has been scanned for viruses and
dangerous content by MailScanner, and is
believed to be clean.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid>