Date: Thu, 30 Sep 2021 23:23:44 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Jan Beich <jbeich@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: fc75da3a3b2a - main - graphics/libjxl: fix build on powerpc64* Message-ID: <YVYq4DdMrnK6QTxI@KGPE-D16> In-Reply-To: <y27d-6dxe-wny@FreeBSD.org> References: <202109301550.18UFoo8j096475__2724.79643333412$1633017067$gmane$org@gitrepo.freebsd.org> <y27d-6dxe-wny@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ShryPTP3AdZgwy6I Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable No, I don't have a Google account. On 21-09-30 21:50:21, Jan Beich wrote: > Piotr Kubaj <pkubaj@FreeBSD.org> writes: >=20 > > The include in cpu.cc is not actually necessary, so I did not inclu= de anything for FreeBSD. > [...] > > +--- tools/cpu/cpu.cc.orig 2021-09-30 15:38:45 UTC > > ++++ tools/cpu/cpu.cc > > +@@ -19,7 +19,9 @@ > > + #endif > > +=20 > > + #if JXL_ARCH_PPC > > +-#include <sys/platform/ppc.h> // __ppc_get_timebase_freq > > ++#if linux > > ++#include <sys/platform/ppc.h> // NOLINT __ppc_get_timebase_freq > > ++#endif > > + #endif >=20 > Can you file a bug via https://github.com/libjxl/libjxl/issues/new ? > That include is probably unused even on Linux after 5175d11717f3 > removed __ppc_get_timebase_freq. >=20 > Note, if you can't sign Google CLA don't submit a fix. Otherwise, upstream > will refuse to read the rationale (PR description), let alone the patch e= =2Eg., > https://github.com/libjxl/libjxl/pull/193 --ShryPTP3AdZgwy6I Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmFWKuAACgkQelmbhSCD nJ0CuA/9HSVRQ47juSmnHxvdX+Xz+EJQcgr7L3nHFJcsQ5UyuRVDo3fDlydtQ93s LBX9YF5Z1VMH4RyqzkqgWMbWQPh57nE4XaDwP1cfmvWJrNDpLQceBdEbAQivMxhb LFw9r+gPabc4aig4T5fVmQccLaubBnjHtiBxK9YW8kb2UvnWj3oMXq1+fbyM/QZB lQo6pZMZ+o5hpbtxxOJcf3RvsWUYFsDTdjXbFR3Sp+WcHH2+3CVcdzBSOTCoMwmk VZLtXiZGKxEJQ46Bjl4fuYliL7Asr7ZmqTCDhTo6m1/JrxVrmcZf8qXngECS+i8T LvclJG73qUw+bJxhSDfiCWvgaHI8g/Jb5cElnMjIUELvDbH38DiqW51kpVC5NKE3 iLYyIxhQiJgST5xpdjJi/sSgkbYeWi/g+q0rXCFX5W2vpJ15mZChNtX+JTy2Vf+t jeOj2AXSd8Psmb+JVuSE2kO2S5pVqaaDNDGlNx9+X4b+GcKDMZK1D8/bGpfGjfzP 64IJkebJUWHFG49BmUWVxN77wMTMK9LbI04XFhiyc2YldEUVsGr+a1vxWkO81tcx o5oVKY4tqxWVeAmnTQ3jyTRL29KK7yLQKTbHJ0Qu+lxFCf2K2uAasu8lEQOQyQdB 7jTWW4BGXORuUu9yTXLmVAVoTPEGeIn9V0F/FiZUZ/jZlE5VyoM= =lTub -----END PGP SIGNATURE----- --ShryPTP3AdZgwy6I--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YVYq4DdMrnK6QTxI>