Date: Sun, 3 Nov 2013 04:20:01 GMT From: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= <olivier@cochard.me> To: freebsd-bugs@FreeBSD.org Subject: Re: misc/183598: netstat and wrong display of humanized packets counter Message-ID: <201311030420.rA34K1mp003565@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR misc/183598; it has been noted by GNATS. From: =?ISO-8859-1?Q?Olivier_Cochard=2DLabb=E9?= <olivier@cochard.me> To: bug-followup@freebsd.org, olivier@cochard.me Cc: Subject: Re: misc/183598: netstat and wrong display of humanized packets counter Date: Sun, 3 Nov 2013 05:16:35 +0100 --047d7b5d45d0e19a1004ea3e1120 Content-Type: multipart/alternative; boundary=047d7b5d45d0e19a0104ea3e111e --047d7b5d45d0e19a0104ea3e111e Content-Type: text/plain; charset=ISO-8859-1 Here is a proposed patch: - Byte counters use default 1024 divisor - non-byte counters (packet, errors, drop, collisions, etc...) use 1000 divisor New counters are more "human", here is an example with the old and new netstat: root@orange# netstat -ihw 1 input (Total) output packets errs idrops bytes packets errs bytes colls 956K 0 0 86M 956K 0 86M 0 975K 0 0 88M 975K 0 88M 0 938K 0 0 84M 938K 0 84M 0 961K 0 0 86M 961K 0 86M 0 984K 0 0 88M 984K 0 88M 0 970K 0 0 87M 970K 0 87M 0 941K 0 0 85M 941K 0 85M 0 ^C root@orange# /usr/obj/usr/local/BSDRP/BSDRP/FreeBSD/src/usr.bin/netstat/netstat -ihw 1 input (Total) output packets errs idrops bytes packets errs bytes colls 1.0M 0 0 89M 1.0M 0 89M 0 953k 0 0 84M 953k 0 84M 0 986k 0 0 86M 986k 0 86M 0 991k 0 0 87M 991k 0 87M 0 994k 0 0 87M 994k 0 87M 0 976k 0 0 86M 976k 0 86M 0 ^C Regards, Olivier --047d7b5d45d0e19a0104ea3e111e Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+SGVyZSBpcyBhIHByb3Bvc2VkIHBhdGNoOjxicj4tIEJ5dGUgY291bnRl cnMgdXNlIGRlZmF1bHQgMTAyNCBkaXZpc29yPGJyPi0gbm9uLWJ5dGUgY291bnRlcnMgKHBhY2tl dCwgZXJyb3JzLCBkcm9wLCBjb2xsaXNpb25zLCBldGMuLi4pIHVzZSAxMDAwIGRpdmlzb3I8YnI+ PGJyPk5ldyBjb3VudGVycyBhcmUgbW9yZSAmcXVvdDtodW1hbiZxdW90OywgaGVyZSBpcyBhbiBl eGFtcGxlIHdpdGggdGhlIG9sZCBhbmQgbmV3IG5ldHN0YXQ6PGJyPg0KDQo8YnI+cm9vdEBvcmFu Z2UjIG5ldHN0YXQgLWlodyAxPGJyPqAgoCCgIKAgoCCgIGlucHV0IKAgoCCgIKAoVG90YWwpIKAg oCCgIKAgoCBvdXRwdXQ8YnI+oCCgcGFja2V0cyCgZXJycyBpZHJvcHMgoCCgIKBieXRlcyCgIKBw YWNrZXRzIKBlcnJzIKAgoCCgYnl0ZXMgY29sbHM8YnI+oCCgIKAgOTU2SyCgIKAgMCCgIKAgMCCg IKAgoCCgODZNIKAgoCCgIDk1NksgoCCgIDAgoCCgIKAgoDg2TSCgIKAgMDxicj4NCg0KoCCgIKAg OTc1SyCgIKAgMCCgIKAgMCCgIKAgoCCgODhNIKAgoCCgIDk3NUsgoCCgIDAgoCCgIKAgoDg4TSCg IKAgMDxicj6gIKAgoCA5MzhLIKAgoCAwIKAgoCAwIKAgoCCgIKA4NE0goCCgIKAgOTM4SyCgIKAg MCCgIKAgoCCgODRNIKAgoCAwPGJyPqAgoCCgIDk2MUsgoCCgIDAgoCCgIDAgoCCgIKAgoDg2TSCg IKAgoCA5NjFLIKAgoCAwIKAgoCCgIKA4Nk0goCCgIDA8YnI+oCCgIKAgOTg0SyCgIKAgMCCgIKAg MCCgIKAgoCCgODhNIKAgoCCgIDk4NEsgoCCgIDAgoCCgIKAgoDg4TSCgIKAgMDxicj4NCg0KoCCg IKAgOTcwSyCgIKAgMCCgIKAgMCCgIKAgoCCgODdNIKAgoCCgIDk3MEsgoCCgIDAgoCCgIKAgoDg3 TSCgIKAgMDxicj6gIKAgoCA5NDFLIKAgoCAwIKAgoCAwIKAgoCCgIKA4NU0goCCgIKAgOTQxSyCg IKAgMCCgIKAgoCCgODVNIKAgoCAwPGJyPl5DPGJyPnJvb3RAb3JhbmdlIyAvdXNyL29iai91c3Iv bG9jYWwvQlNEUlAvQlNEUlAvRnJlZUJTRC9zcmMvdXNyLmJpbi9uZXRzdGF0L25ldHN0YXQgLWlo dyAxIKAgoCCgPGJyPg0KDQqgIKAgoCCgIKAgoCBpbnB1dCCgIKAgoCCgKFRvdGFsKSCgIKAgoCCg IKAgb3V0cHV0PGJyPqAgoHBhY2tldHMgoGVycnMgaWRyb3BzIKAgoCCgYnl0ZXMgoCCgcGFja2V0 cyCgZXJycyCgIKAgoGJ5dGVzIGNvbGxzPGJyPqAgoCCgIDEuME0goCCgIDAgoCCgIDAgoCCgIKAg oDg5TSCgIKAgoCAxLjBNIKAgoCAwIKAgoCCgIKA4OU0goCCgIDA8YnI+oCCgIKAgOTUzayCgIKAg MCCgIKAgMCCgIKAgoCCgODRNIKAgoCCgIDk1M2sgoCCgIDAgoCCgIKAgoDg0TSCgIKAgMDxicj4N Cg0KoCCgIKAgOTg2ayCgIKAgMCCgIKAgMCCgIKAgoCCgODZNIKAgoCCgIDk4NmsgoCCgIDAgoCCg IKAgoDg2TSCgIKAgMDxicj6gIKAgoCA5OTFrIKAgoCAwIKAgoCAwIKAgoCCgIKA4N00goCCgIKAg OTkxayCgIKAgMCCgIKAgoCCgODdNIKAgoCAwPGJyPqAgoCCgIDk5NGsgoCCgIDAgoCCgIDAgoCCg IKAgoDg3TSCgIKAgoCA5OTRrIKAgoCAwIKAgoCCgIKA4N00goCCgIDA8YnI+oCCgIKAgOTc2ayCg IKAgMCCgIKAgMCCgIKAgoCCgODZNIKAgoCCgIDk3NmsgoCCgIDAgoCCgIKAgoDg2TSCgIKAgMDxi cj4NCg0KXkM8YnI+PGJyPlJlZ2FyZHMsPGJyPjxicj5PbGl2aWVyPC9kaXY+DQo= --047d7b5d45d0e19a0104ea3e111e-- --047d7b5d45d0e19a1004ea3e1120 Content-Type: text/plain; charset=US-ASCII; name="netstat.patch.txt" Content-Disposition: attachment; filename="netstat.patch.txt" Content-Transfer-Encoding: base64 X-Attachment-Id: f_hnjrll3g0 SW5kZXg6IHVzci5iaW4vbmV0c3RhdC9pZi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHVzci5iaW4vbmV0c3Rh dC9pZi5jCShyZXZpc2lvbiAyNTc1MDQpCisrKyB1c3IuYmluL25ldHN0YXQvaWYuYwkod29ya2lu ZyBjb3B5KQpAQCAtMTYwLDcgKzE2MCw3IEBACiAgKiBEaXNwbGF5IGEgZm9ybWF0dGVkIHZhbHVl LCBvciBhICctJyBpbiB0aGUgc2FtZSBzcGFjZS4KICAqLwogc3RhdGljIHZvaWQKLXNob3dfc3Rh dChjb25zdCBjaGFyICpmbXQsIGludCB3aWR0aCwgdV9sb25nIHZhbHVlLCBzaG9ydCBzaG93dmFs dWUpCitzaG93X3N0YXQoY29uc3QgY2hhciAqZm10LCBpbnQgd2lkdGgsIHVfbG9uZyB2YWx1ZSwg c2hvcnQgc2hvd3ZhbHVlLCBzaG9ydCBub3RieXRlKQogewogCWNvbnN0IGNoYXIgKmxzZXAsICpy c2VwOwogCWNoYXIgbmV3Zm10WzMyXTsKQEAgLTE4Niw4ICsxODYsMTQgQEAKIAkJY2hhciBidWZb NV07CiAKIAkJLyogRm9ybWF0IGluIGh1bWFuIHJlYWRhYmxlIGZvcm0uICovCi0JCWh1bWFuaXpl X251bWJlcihidWYsIHNpemVvZihidWYpLCAoaW50NjRfdCl2YWx1ZSwgIiIsCi0JCSAgICBITl9B VVRPU0NBTEUsIEhOX05PU1BBQ0UgfCBITl9ERUNJTUFMKTsKKwkJaWYgKG5vdGJ5dGUgPT0gMCkg eworCQkJaHVtYW5pemVfbnVtYmVyKGJ1Ziwgc2l6ZW9mKGJ1ZiksIChpbnQ2NF90KXZhbHVlLCAi IiwKKwkJCSAgICBITl9BVVRPU0NBTEUsIEhOX05PU1BBQ0UgfCBITl9ERUNJTUFMKTsKKwkJfSBl bHNlIHsKKwkJCWh1bWFuaXplX251bWJlcihidWYsIHNpemVvZihidWYpLCAoaW50NjRfdCl2YWx1 ZSwgIiIsCisJCQkgICAgSE5fQVVUT1NDQUxFLCBITl9OT1NQQUNFIHwgSE5fREVDSU1BTCB8CisJ CQkgICAgSE5fRElWSVNPUl8xMDAwKTsKKwkJfQogCQlzcHJpbnRmKG5ld2ZtdCwgIiVzJSUlZHMl cyIsIGxzZXAsIHdpZHRoLCByc2VwKTsKIAkJcHJpbnRmKG5ld2ZtdCwgYnVmKTsKIAl9IGVsc2Ug ewpAQCAtNDQ0LDIwICs0NTAsMjAgQEAKIAkJCWlmYWRkcmFkZHIgPSAodV9sb25nKVRBSUxRX05F WFQoJmlmYWRkci5pZmEsIGlmYV9saW5rKTsKIAkJfQogCi0JCXNob3dfc3RhdCgibHUiLCA4LCBp cGFja2V0cywgbGlua19sYXllcnxuZXR3b3JrX2xheWVyKTsKLQkJc2hvd19zdGF0KCJsdSIsIDUs IGllcnJvcnMsIGxpbmtfbGF5ZXIpOwotCQlzaG93X3N0YXQoImx1IiwgNSwgaWRyb3BzLCBsaW5r X2xheWVyKTsKKwkJc2hvd19zdGF0KCJsdSIsIDgsIGlwYWNrZXRzLCBsaW5rX2xheWVyfG5ldHdv cmtfbGF5ZXIsIDEpOworCQlzaG93X3N0YXQoImx1IiwgNSwgaWVycm9ycywgbGlua19sYXllciwg MSk7CisJCXNob3dfc3RhdCgibHUiLCA1LCBpZHJvcHMsIGxpbmtfbGF5ZXIsIDEpOwogCQlpZiAo YmZsYWcpCi0JCQlzaG93X3N0YXQoImx1IiwgMTAsIGlieXRlcywgbGlua19sYXllcnxuZXR3b3Jr X2xheWVyKTsKKwkJCXNob3dfc3RhdCgibHUiLCAxMCwgaWJ5dGVzLCBsaW5rX2xheWVyfG5ldHdv cmtfbGF5ZXIsIDApOwogCi0JCXNob3dfc3RhdCgibHUiLCA4LCBvcGFja2V0cywgbGlua19sYXll cnxuZXR3b3JrX2xheWVyKTsKLQkJc2hvd19zdGF0KCJsdSIsIDUsIG9lcnJvcnMsIGxpbmtfbGF5 ZXIpOworCQlzaG93X3N0YXQoImx1IiwgOCwgb3BhY2tldHMsIGxpbmtfbGF5ZXJ8bmV0d29ya19s YXllciwgMSk7CisJCXNob3dfc3RhdCgibHUiLCA1LCBvZXJyb3JzLCBsaW5rX2xheWVyLDEpOwog CQlpZiAoYmZsYWcpCi0JCQlzaG93X3N0YXQoImx1IiwgMTAsIG9ieXRlcywgbGlua19sYXllcnxu ZXR3b3JrX2xheWVyKTsKKwkJCXNob3dfc3RhdCgibHUiLCAxMCwgb2J5dGVzLCBsaW5rX2xheWVy fG5ldHdvcmtfbGF5ZXIsIDApOwogCi0JCXNob3dfc3RhdCgiTlJTbHUiLCA1LCBjb2xsaXNpb25z LCBsaW5rX2xheWVyKTsKKwkJc2hvd19zdGF0KCJOUlNsdSIsIDUsIGNvbGxpc2lvbnMsIGxpbmtf bGF5ZXIsIDEpOwogCQlpZiAoZGZsYWcpCi0JCQlzaG93X3N0YXQoIkxTZCIsIDQsIGRyb3BzLCBs aW5rX2xheWVyKTsKKwkJCXNob3dfc3RhdCgiTFNkIiwgNCwgZHJvcHMsIGxpbmtfbGF5ZXIsIDEp OwogCQlwdXRjaGFyKCdcbicpOwogCiAJCWlmIChhZmxhZyAmJiBpZmFkZHJmb3VuZCkgewpAQCAt NjM3LDE4ICs2NDMsMTggQEAKIAkJCWV4aXQoMSk7CiAJCX07CiAJCWlmICghZmlyc3QpIHsKLQkJ CXNob3dfc3RhdCgibHUiLCAxMCwgaWZuZXQuaWZfaXBhY2tldHMgLSBpcC0+aWZ0X2lwLCAxKTsK LQkJCXNob3dfc3RhdCgibHUiLCA1LCBpZm5ldC5pZl9pZXJyb3JzIC0gaXAtPmlmdF9pZSwgMSk7 Ci0JCQlzaG93X3N0YXQoImx1IiwgNSwgaWZuZXQuaWZfaXFkcm9wcyAtIGlwLT5pZnRfaWQsIDEp OwotCQkJc2hvd19zdGF0KCJsdSIsIDEwLCBpZm5ldC5pZl9pYnl0ZXMgLSBpcC0+aWZ0X2liLCAx KTsKLQkJCXNob3dfc3RhdCgibHUiLCAxMCwgaWZuZXQuaWZfb3BhY2tldHMgLSBpcC0+aWZ0X29w LCAxKTsKLQkJCXNob3dfc3RhdCgibHUiLCA1LCBpZm5ldC5pZl9vZXJyb3JzIC0gaXAtPmlmdF9v ZSwgMSk7Ci0JCQlzaG93X3N0YXQoImx1IiwgMTAsIGlmbmV0LmlmX29ieXRlcyAtIGlwLT5pZnRf b2IsIDEpOworCQkJc2hvd19zdGF0KCJsdSIsIDEwLCBpZm5ldC5pZl9pcGFja2V0cyAtIGlwLT5p ZnRfaXAsIDEsIDEpOworCQkJc2hvd19zdGF0KCJsdSIsIDUsIGlmbmV0LmlmX2llcnJvcnMgLSBp cC0+aWZ0X2llLCAxLCAxKTsKKwkJCXNob3dfc3RhdCgibHUiLCA1LCBpZm5ldC5pZl9pcWRyb3Bz IC0gaXAtPmlmdF9pZCwgMSwgMSk7CisJCQlzaG93X3N0YXQoImx1IiwgMTAsIGlmbmV0LmlmX2li eXRlcyAtIGlwLT5pZnRfaWIsIDEsIDApOworCQkJc2hvd19zdGF0KCJsdSIsIDEwLCBpZm5ldC5p Zl9vcGFja2V0cyAtIGlwLT5pZnRfb3AsIDEsIDEpOworCQkJc2hvd19zdGF0KCJsdSIsIDUsIGlm bmV0LmlmX29lcnJvcnMgLSBpcC0+aWZ0X29lLCAxLCAxKTsKKwkJCXNob3dfc3RhdCgibHUiLCAx MCwgaWZuZXQuaWZfb2J5dGVzIC0gaXAtPmlmdF9vYiwgMSwgMCk7CiAJCQlzaG93X3N0YXQoIk5S U2x1IiwgNSwKLQkJCSAgICBpZm5ldC5pZl9jb2xsaXNpb25zIC0gaXAtPmlmdF9jbywgMSk7CisJ CQkgICAgaWZuZXQuaWZfY29sbGlzaW9ucyAtIGlwLT5pZnRfY28sIDEsIDEpOwogCQkJaWYgKGRm bGFnKQogCQkJCXNob3dfc3RhdCgiTFN1IiwgNSwKLQkJCQkgICAgaWZuZXQuaWZfc25kLmlmcV9k cm9wcyAtIGlwLT5pZnRfZHIsIDEpOworCQkJCSAgICBpZm5ldC5pZl9zbmQuaWZxX2Ryb3BzIC0g aXAtPmlmdF9kciwgMSwgMSk7CiAJCX0KIAkJaXAtPmlmdF9pcCA9IGlmbmV0LmlmX2lwYWNrZXRz OwogCQlpcC0+aWZ0X2llID0gaWZuZXQuaWZfaWVycm9yczsKQEAgLTY4OCwxNyArNjk0LDE3IEBA CiAJCQlvZmYgPSAodV9sb25nKVRBSUxRX05FWFQoJmlmbmV0LCBpZl9saW5rKTsKIAkJfQogCQlp ZiAoIWZpcnN0KSB7Ci0JCQlzaG93X3N0YXQoImx1IiwgMTAsIHN1bS0+aWZ0X2lwIC0gdG90YWwt PmlmdF9pcCwgMSk7Ci0JCQlzaG93X3N0YXQoImx1IiwgNSwgc3VtLT5pZnRfaWUgLSB0b3RhbC0+ aWZ0X2llLCAxKTsKLQkJCXNob3dfc3RhdCgibHUiLCA1LCBzdW0tPmlmdF9pZCAtIHRvdGFsLT5p ZnRfaWQsIDEpOwotCQkJc2hvd19zdGF0KCJsdSIsIDEwLCBzdW0tPmlmdF9pYiAtIHRvdGFsLT5p ZnRfaWIsIDEpOwotCQkJc2hvd19zdGF0KCJsdSIsIDEwLCBzdW0tPmlmdF9vcCAtIHRvdGFsLT5p ZnRfb3AsIDEpOwotCQkJc2hvd19zdGF0KCJsdSIsIDUsIHN1bS0+aWZ0X29lIC0gdG90YWwtPmlm dF9vZSwgMSk7Ci0JCQlzaG93X3N0YXQoImx1IiwgMTAsIHN1bS0+aWZ0X29iIC0gdG90YWwtPmlm dF9vYiwgMSk7Ci0JCQlzaG93X3N0YXQoIk5SU2x1IiwgNSwgc3VtLT5pZnRfY28gLSB0b3RhbC0+ aWZ0X2NvLCAxKTsKKwkJCXNob3dfc3RhdCgibHUiLCAxMCwgc3VtLT5pZnRfaXAgLSB0b3RhbC0+ aWZ0X2lwLCAxLCAxKTsKKwkJCXNob3dfc3RhdCgibHUiLCA1LCBzdW0tPmlmdF9pZSAtIHRvdGFs LT5pZnRfaWUsIDEsIDEpOworCQkJc2hvd19zdGF0KCJsdSIsIDUsIHN1bS0+aWZ0X2lkIC0gdG90 YWwtPmlmdF9pZCwgMSwgMSk7CisJCQlzaG93X3N0YXQoImx1IiwgMTAsIHN1bS0+aWZ0X2liIC0g dG90YWwtPmlmdF9pYiwgMSwgMCk7CisJCQlzaG93X3N0YXQoImx1IiwgMTAsIHN1bS0+aWZ0X29w IC0gdG90YWwtPmlmdF9vcCwgMSwgMSk7CisJCQlzaG93X3N0YXQoImx1IiwgNSwgc3VtLT5pZnRf b2UgLSB0b3RhbC0+aWZ0X29lLCAxLCAxKTsKKwkJCXNob3dfc3RhdCgibHUiLCAxMCwgc3VtLT5p ZnRfb2IgLSB0b3RhbC0+aWZ0X29iLCAxLCAwKTsKKwkJCXNob3dfc3RhdCgiTlJTbHUiLCA1LCBz dW0tPmlmdF9jbyAtIHRvdGFsLT5pZnRfY28sIDEsIDEpOwogCQkJaWYgKGRmbGFnKQogCQkJCXNo b3dfc3RhdCgiTFN1IiwgNSwKLQkJCQkgICAgc3VtLT5pZnRfZHIgLSB0b3RhbC0+aWZ0X2RyLCAx KTsKKwkJCQkgICAgc3VtLT5pZnRfZHIgLSB0b3RhbC0+aWZ0X2RyLCAxLCAxKTsKIAkJfQogCQkq dG90YWwgPSAqc3VtOwogCX0K --047d7b5d45d0e19a1004ea3e1120--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201311030420.rA34K1mp003565>