Date: Thu, 2 Jul 1998 12:59:47 -0400 From: ac199@hwcn.org To: "Vanilla I. Shu" <vanilla@FreeBSD.ORG> Cc: ports@FreeBSD.ORG, Jun-ichiro itojun Itoh <itojun@itojun.org> Subject: Re: cvs commit: ports/net/arpwatch Makefile ports/net/arpwatch/patches patch-ab Message-ID: <19980702125947.B1223@zappo> In-Reply-To: <199807021045.DAA01940@freefall.freebsd.org>; from Vanilla I. Shu on Thu, Jul 02, 1998 at 03:45:37AM -0700 References: <199807021045.DAA01940@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Jul 02, 1998 at 03:45:37AM -0700, Vanilla I. Shu wrote:
[...]
> Added files:
> net/arpwatch/patches patch-ab
> Log:
> Portlint and strip binary file.
How about the following patch to portlint?
*** work/portlint.pl Thu Jul 2 12:42:37 1998
--- /usr/local/bin/portlint Thu Jul 2 12:47:07 1998
***************
*** 219,224 ****
--- 219,231 ----
next;
}
+ $strip = `/usr/bin/file /usr/local/$_`;
+ if ($strip =~ /not stripped/) {
+ &perror("WARN: $_ not stripped. Make ".
+ "sure to either strip or set ".
+ "NO_PACKAGE=\"doesn't strip\".");
+ }
+
if ($_ =~ /^\//) {
&perror("FATAL: use of full pathname disallowed ".
"on line $. in $file.");
It's fairly simplistic and certainly won't catch everything, but
maybe it'll get some of them. I'd WARN conditionally on NO_PACKAGE,
but I'm not sure of the proper way to pass info from &checkmakefile
to &checkplist.
[Hmm... looking over that again, I think there needs to be a
corresponding local($strip) = ""; line.... I don't do enough perl
to think of things like that... :]
--
This .sig is not innovative, witty, or profund.
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?19980702125947.B1223>