Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jun 2021 16:08:33 +0200
From:      Michael Gmelin <grembo@freebsd.org>
To:        Mathieu Arnold <mat@freebsd.org>
Cc:        Dan Langille <dan@langille.org>, Sunpoet Po-Chuan Hsieh <sunpoet@freebsd.org>, ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: ba91d6adf07f - main - devel/p5-Throwable: Update to 0.201
Message-ID:  <20210628160833.10c02a68@bsd64.grem.de>
In-Reply-To: <20210628160043.1d6a2514@bsd64.grem.de>
References:  <202106251346.15PDkr9u088868@gitrepo.freebsd.org> <cb4aeb16-20e9-4f04-9502-b737ef29c20a@www.fastmail.com> <abea27bf-cd95-4953-828b-f6aadc1a9113@www.fastmail.com> <20210628124240.yif2bxvld47qnnag@aching.in.mat.cc> <20210628160043.1d6a2514@bsd64.grem.de>

next in thread | previous in thread | raw e-mail | index | archive | help


On Mon, 28 Jun 2021 16:00:43 +0200
Michael Gmelin <grembo@freebsd.org> wrote:

> On Mon, 28 Jun 2021 14:42:40 +0200
> Mathieu Arnold <mat@freebsd.org> wrote:
> 
> > On Sat, Jun 26, 2021 at 11:23:20AM -0400, Dan Langille wrote:  
> > > On Sat, Jun 26, 2021, at 10:51 AM, Dan Langille wrote:    
> > > > On Fri, Jun 25, 2021, at 9:46 AM, Po-Chuan Hsieh wrote:    
> > > > > The branch main has been updated by sunpoet:
> > > > > 
> > > > > URL: 
> > > > > https://cgit.FreeBSD.org/ports/commit/?id=ba91d6adf07f6f21e45a811fbd1266a569b112e9
> > > > > 
> > > > > commit ba91d6adf07f6f21e45a811fbd1266a569b112e9
> > > > > Author:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > > > > AuthorDate: 2021-06-25 13:40:22 +0000
> > > > > Commit:     Po-Chuan Hsieh <sunpoet@FreeBSD.org>
> > > > > CommitDate: 2021-06-25 13:40:22 +0000
> > > > > 
> > > > >     devel/p5-Throwable: Update to 0.201
> > > > >     
> > > > >     - Add LICENSE_FILE
> > > > >     
> > > > >     Changes:
> > > > > https://metacpan.org/dist/Throwable/changes ---
> > > > >  devel/p5-Throwable/Makefile | 6 ++++--
> > > > >  devel/p5-Throwable/distinfo | 5 +++--
> > > > >  2 files changed, 7 insertions(+), 4 deletions(-)
> > > > > 
> > > > > diff --git a/devel/p5-Throwable/Makefile
> > > > > b/devel/p5-Throwable/Makefile index a3cce9d4b73e..e030f45e803e
> > > > > 100644 --- a/devel/p5-Throwable/Makefile
> > > > > +++ b/devel/p5-Throwable/Makefile
> > > > > @@ -1,5 +1,5 @@
> > > > >  PORTNAME=	Throwable
> > > > > -PORTVERSION=	0.200013
> > > > > +PORTVERSION=	0.201    
> > > > 
> > > > This is not an increase in version.
> > > > 
> > > > $ pkg version --test-version 0.201 0.200003
> > > > <
> > > > 
> > > > 
> > > > I found it while building mail/p5-Email-Sender:
> > > > 
> > > > [122amd64-default] Installing p5-Throwable-0.201...
> > > > [122amd64-default] `-- Installing p5-Devel-StackTrace-2.04...
> > > > [122amd64-default] `-- Extracting p5-Devel-StackTrace-2.04:
> > > > ..... done [122amd64-default] Extracting p5-Throwable-0.201:
> > > > ....... done ===>   p5-Email-Sender-1.300031_2 depends on
> > > > package: p5-Throwable>=0.200003 - not found
> > > > 
> > > > 
> > > > re: 
> > > > https://services.unixathome.org/poudriere/build.html?mastername=122amd64-default&build=2021-06-26_14h32m52s
> > > >    
> > > 
> > > I have opened an upstream issue:
> > > https://github.com/rjbs/Throwable/issues/20    
> > 
> > Upstream has nothing to do with it, the way Perl versions work is
> > not the same as the way FreeBSD versions work.
> >   
> 
> So ideally, our versioning should have been 0.200.003 from the start,

or rather 0.200.3...

-m

> so that updating to 0.201 would've done the right thing (or
> alternatively, go from 0.200003 to 0.201000) and now that they've
> tagged 1.000 upstream it should be okay, but on the next update (e.g.
> to 1.100200) we need to make sure to use a dot in versioning
> (1.100.200)?
> 
> Very friendly upstream by the way.
> 
> -m
> 



-- 
Michael Gmelin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210628160833.10c02a68>