Date: Sat, 2 May 1998 00:01:40 -0400 (EDT) From: Chuck Robey <chuckr@glue.umd.edu> To: John Birrell <jb@cimlogic.com.au> Cc: jkh@time.cdrom.com, FreeBSD-current@FreeBSD.ORG Subject: Re: groff/devascii Message-ID: <Pine.BSF.3.96.980501235606.15307L-100000@localhost> In-Reply-To: <199805020413.OAA08074@cimlogic.com.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 2 May 1998, John Birrell wrote: > Chuck Robey wrote: > > If it is, could you give me a guess as to why it would been seen in a > > buildworld, but not in a make from gnu/usr.bin/groff? That's the part > > that I found confusing. > > buildworld builds things into /usr/obj/usr/src/tmp and executes them > for the rest of the build. Only when all things have been built using > the new tools does it remove DESTDIR and allow programs to get installed > in /usr/bin etc. When you did a make from gnu/usr.bin/groff, I bet you > didn't set DESTDIR to /usr/obj/usr/src/tmp, so you were using the > old (= working) version of bc. If you had done a 'make all && make > install' in src/gnu/usr.bin/bc, then groff/devascii would have failed. > > This is an example of what is good about the build process. It doesn't > clobber anything if the buildworld fails. > > The problem here, though, is that the changes to bc were obviously > committed without the developer doing a make world. Well, a minimal fix would be to change the line 240 / 10 | bc to 240 / 10 | bc | sed -e "1d" which would trim out the first line. I took a look at the bc code, it wasn't obvious how to get that echoing off ... it's likely some change in readline, I think. I'll commit this myself, after I do a test buildworld, if I don't hear any howls. It's in /usr/src/gnu/usr.bin/groff/Makefile.tty (thanks for that tip, John, I'd never have found it!) > > -- > John Birrell - jb@cimlogic.com.au; jb@freebsd.org http://www.cimlogic.com.au/ > CIMlogic Pty Ltd, GPO Box 117A, Melbourne Vic 3001, Australia +61 418 353 137 > > ----------------------------+----------------------------------------------- Chuck Robey | Interests include any kind of voice or data chuckr@glue.umd.edu | communications topic, C programming, and Unix. 213 Lakeside Drive Apt T-1 | Greenbelt, MD 20770 | I run Journey2 and picnic (FreeBSD-current) (301) 220-2114 | and jaunt (NetBSD). ----------------------------+----------------------------------------------- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.3.96.980501235606.15307L-100000>