Date: Sun, 31 Jul 2011 10:21:01 +0300 From: C++ RTMP Server Support <support@rtmpd.com> To: Doug Barton <dougb@FreeBSD.org> Cc: Jin-Sih Lin <linpct@gmail.com>, cvs-ports@FreeBSD.org, Li-Wen Hsu <lwhsu@FreeBSD.org>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/net/crtmpserver Makefile distinfo pkg-plist ports/net/crtmpserver/files crtmpserver.in Message-ID: <D2E25D19-0A8E-4081-BB71-81EE07A2BC77@rtmpd.com> In-Reply-To: <4E3495B0.3070405@FreeBSD.org> References: <201107301549.p6UFn7rK070976@repoman.freebsd.org> <4E3495B0.3070405@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_ACC0D98D-EA20-401A-8178-AA950F5B22BF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=iso-8859-1
But I set it up. I pick it up from rc.conf settings or default it to =
"/var/run/${name}.pid".
The big difference is that now the pid file is generated by crtmpserver =
(the binary). Now it has --pid parameter. Before, it was generated by =
the script.
If you feel that we should keep the old approach (generate the pid from =
the script, not from the binary), is totally fine with me
Best regards,
Andrei
On Jul 31, 2011, at 2:37 AM, Doug Barton wrote:
> Is there a reason you're not setting pidfile anymore? While on one =
hand
> I think allowing users to specify ${name}_pidfile is usually overkill,
> the pidfile variable is special in rc.subr. If you're going to allow =
the
> user to specify the pidfile location the usual way to do that is:
>=20
> pidfile=3D"${foo_pidfile:-/var/run/foo.pid}"
>=20
> (at some point after load_rc_config). Then use $pidfile throughout the
> rest of the script.
>=20
>=20
> Doug
>=20
>=20
> On 07/30/2011 08:49, Li-Wen Hsu wrote:
>> lwhsu 2011-07-30 15:49:07 UTC
>>=20
>> FreeBSD ports repository
>>=20
>> Modified files:
>> net/crtmpserver Makefile distinfo pkg-plist=20
>> net/crtmpserver/files crtmpserver.in=20
>> Log:
>> - Update to 0.545
>>=20
>> PR: ports/158886 =
http://www.FreeBSD.org/cgi/query-pr.cgi?pr=3D158886
>> Submitted by: Jin-Sih Lin <linpct@gmail.com>
>> Approved by: C++ RTMP Server Support (Andrei) <support@rtmpd.com> =
(maintainer)
>>=20
>> Revision Changes Path
>> 1.4 +10 -11 ports/net/crtmpserver/Makefile
>> 1.2 +2 -2 ports/net/crtmpserver/distinfo
>> 1.3 +7 -13 ports/net/crtmpserver/files/crtmpserver.in
>> 1.2 +2 -21 ports/net/crtmpserver/pkg-plist
>>=20
>> =
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/Makefile.diff?=
&r1=3D1.3&r2=3D1.4&f=3Dh
>> =
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/distinfo.diff?=
&r1=3D1.1&r2=3D1.2&f=3Dh
>> =
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/files/crtmpser=
ver.in.diff?&r1=3D1.2&r2=3D1.3&f=3Dh
>> =
http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net/crtmpserver/pkg-plist.diff=
?&r1=3D1.1&r2=3D1.2&f=3Dh
>>=20
>=20
>=20
>=20
> --=20
>=20
> Nothin' ever doesn't change, but nothin' changes much.
> -- OK Go
>=20
> Breadth of IT experience, and depth of knowledge in the DNS.
> Yours for the right price. :) http://SupersetSolutions.com/
>=20
------
C++ RTMP Server Support
Email: support@rtmpd.com
Web: http://www.rtmpd.com
--Apple-Mail=_ACC0D98D-EA20-401A-8178-AA950F5B22BF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D2E25D19-0A8E-4081-BB71-81EE07A2BC77>