Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 01 May 2021 00:45:23 +0200
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Rene Ladan <rene@freebsd.org>
Cc:        ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org
Subject:   Re: git: af459b5bcc0f - main - news/sabnzbdplus: use archivers/par2cmdline
Message-ID:  <5z03-tmrg-wny@FreeBSD.org>
References:  <202104301135.13UBZYN7012096__15839.1882128612$1619782544$gmane$org@gitrepo.freebsd.org> <pmyc-vvj4-wny@FreeBSD.org> <YIw9YfVzw/uWjvEv@freefall.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Rene Ladan <rene@freebsd.org> writes:

> On Fri, Apr 30, 2021 at 01:53:03PM +0200, Jan Beich wrote:
>
>> Rene Ladan <rene@FreeBSD.org> writes:
>> 
>> > The branch main has been updated by rene:
>> >
>> > URL: https://cgit.FreeBSD.org/ports/commit/?id=af459b5bcc0fee9c6353955f8a48cf26a93051b5
>> >
>> > commit af459b5bcc0fee9c6353955f8a48cf26a93051b5
>> > Author:     Rene Ladan <rene@FreeBSD.org>
>> > AuthorDate: 2021-04-30 11:34:06 +0000
>> > Commit:     Rene Ladan <rene@FreeBSD.org>
>> > CommitDate: 2021-04-30 11:34:06 +0000
>> >
>> >     news/sabnzbdplus: use archivers/par2cmdline
>> >     
>> >     Previously this port used archivers/par2cmdline-tbb, but that port has
>> >     expired in favor of par2cmdline.
>> >     
>> >     While here pet portclippy.
>> 
>> Can you land the patch in bug 250411 (broken by "pet portclippy") as well?
>
> How is that related, except for being about the same port?

This commit created extra work due to mixing style bits with funcitonal
changes into one blob. Which part was functional, only RUN_DEPENDS?
Applying bug 250411 now requires un-doing then re-doing the style bits,
which would be easier if this commit was split in two, like often done
in src/ land and facilitated by Git.

Sorry, my original mail was worded poorly.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5z03-tmrg-wny>