Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 27 Sep 2009 16:55:10 +0200
From:      "Simon L. Nielsen" <simon@FreeBSD.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        src-committers@freebsd.org, Pawel Jakub Dawidek <pjd@FreeBSD.org>, svn-src-all@freebsd.org, Thomas Backman <serenity@exscape.org>, svn-src-head@freebsd.org, Dag-Erling Sm??rgrav <des@des.no>
Subject:   Re: svn commit: r197498 - head/cddl/contrib/opensolaris/cmd/zfs
Message-ID:  <20090927145509.GG1495@arthur.nitro.dk>
In-Reply-To: <20090927070220.GA18022@FreeBSD.org>
References:  <200909251824.n8PIOLte036513@svn.freebsd.org> <C96010E7-01B1-410E-B492-CFAC21069758@exscape.org> <20090925191416.GA1597@garage.freebsd.pl> <86tyyph1jl.fsf@ds4.des.no> <20090927070220.GA18022@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2009.09.27 07:02:21 +0000, Alexey Dokuchaev wrote:
> On Sat, Sep 26, 2009 at 10:51:58PM +0200, Dag-Erling Sm??rgrav wrote:
> > Pawel Jakub Dawidek <pjd@FreeBSD.org> writes:
> > > I didn't, thanks. Unfortunately svn doesn't even allow forced commits,
> > > which is a paintful regression compared to cvs.
> > 
> > Subversion does allow editing a log message after the fact, but our
> > commit scripts prohibit it.  This should IMHO be allowed, and cause a
> > new email to be sent out to note the change.
> 
> I recall that one of the reasons behind prohibition was to avoid issues
> with CVS exporter.

I doubt the CVS exporter would have a problem, though I'm not 100%
sure.  I think the problem is more that svnsync does not pick up the
change, but des knows more about that than I do.

PS. I don't personally have a problem allowing people to edit commit
messages, as long as it's "visible" and we knows what the side-effects
are.

-- 
Simon L. Nielsen



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090927145509.GG1495>