Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 19 Mar 2013 22:27:16 +0000 (UTC)
From:      Martin Matuska <mm@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-projects@freebsd.org
Subject:   svn commit: r248538 - projects/libzfs_core/sys/cddl/contrib/opensolaris/uts/common/fs/zfs
Message-ID:  <201303192227.r2JMRGr0067702@svn.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: mm
Date: Tue Mar 19 22:27:15 2013
New Revision: 248538
URL: http://svnweb.freebsd.org/changeset/base/248538

Log:
  Run zvol_create_minors() only if in non-error case

Modified:
  projects/libzfs_core/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c

Modified: projects/libzfs_core/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c
==============================================================================
--- projects/libzfs_core/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c	Tue Mar 19 22:14:50 2013	(r248537)
+++ projects/libzfs_core/sys/cddl/contrib/opensolaris/uts/common/fs/zfs/dsl_dataset.c	Tue Mar 19 22:27:15 2013	(r248538)
@@ -1289,10 +1289,12 @@ dsl_dataset_snapshot(nvlist_t *snaps, nv
 
 #ifdef __FreeBSD__
 #ifdef _KERNEL
-	for (pair = nvlist_next_nvpair(snaps, NULL); pair != NULL;
-	    pair = nvlist_next_nvpair(snaps, pair)) {
-		char *snapname = nvpair_name(pair);
-		zvol_create_minors(snapname);
+	if (error == 0) {
+		for (pair = nvlist_next_nvpair(snaps, NULL); pair != NULL;
+		    pair = nvlist_next_nvpair(snaps, pair)) {
+			char *snapname = nvpair_name(pair);
+			zvol_create_minors(snapname);
+		}
 	}
 #endif
 #endif



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201303192227.r2JMRGr0067702>