Date: Tue, 29 Mar 2005 09:50:05 GMT From: Yen-Ming Lee <leeym@FreeBSD.org> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/79330: [PATCH] devel/p5-Module-Build: add .packlist in PLIST Message-ID: <200503290950.j2T9o56q095002@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/79330; it has been noted by GNATS.
From: Yen-Ming Lee <leeym@FreeBSD.org>
To: freebsd-gnats-submit@FreeBSD.org, mat@FreeBSD.org,
perl@FreeBSD.org
Cc:
Subject: Re: ports/79330: [PATCH] devel/p5-Module-Build: add .packlist in PLIST
Date: Tue, 29 Mar 2005 17:44:43 +0800
--TRYliJ5NKNqkz5bu
Content-Type: multipart/mixed; boundary="+QahgC5+KEYLbs62"
Content-Disposition: inline
--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=big5
Content-Disposition: inline
On Tue, Mar 29, 2005 at 11:06:51AM +0200, Mathieu Arnold wrote:
> I know about that, and I've been thinking on it hard.
>
> Your PR is just about as inapropriate as possible :-)
>
> because, if you fix it this way, you'll have to fix every other package
> using Module::Build to build, because as it says it, "The default value is
> true" meaning that every other port will have this .packlist. The correct
> solution is either to use the previous version of the port for 5.4 release
> (or to back it out), or to add a create_packlist=false in the appropriate
> part of bsd.port.mk.
Hmm.... I prefer to set create_packlist in bsd.port.mk
BTW, I tried create_packlist=false and it didn't work like what I expected.
We should use create_packlist=0 instead.
Here comes the patch, and I guess this PR should be assigned to portmgr.
--
Yen-Ming Lee [utf7:+Z05fZWYO] | KeyID:0x5EB52E51 | Taipei, Taiwan
--+QahgC5+KEYLbs62
Content-Type: text/plain; charset=big5
Content-Disposition: attachment; filename="bsd.port.mk.diff"
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.511
diff -u -r1.511 bsd.port.mk
--- bsd.port.mk 17 Mar 2005 23:22:07 -0000 1.511
+++ bsd.port.mk 29 Mar 2005 09:36:54 -0000
@@ -1638,6 +1638,7 @@
ALL_TARGET?=
PL_BUILD?= Build
CONFIGURE_ARGS+= \
+ create_packlist=0 \
install_path=lib="${PREFIX}/${SITE_PERL_REL}" \
install_path=arch="${PREFIX}/${SITE_PERL_REL}/${PERL_ARCH}" \
install_path=script="${PREFIX}/bin" \
--+QahgC5+KEYLbs62--
--TRYliJ5NKNqkz5bu
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (FreeBSD)
iQCVAwUBQkkji8nMx0NetS5RAQKV0wP+JKC364xlE8DdEZqUHFrqu5u5++MvJMsE
Uqo/Z5jHJf6ZRfmk9oq0a2YBxTFgUQ6dsmi5OVSnZWR6j+IXFX71KOChGb+nFkG8
vCu4TW+wCKn3ngTzO4rnooVn9WeMH7KnPKPVRMymZG2GovsROJDXFHD5MXSWXIPy
+Kz7OYT11no=
=QIBw
-----END PGP SIGNATURE-----
--TRYliJ5NKNqkz5bu--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200503290950.j2T9o56q095002>