Date: Fri, 19 Jul 2013 21:35:00 +0300 From: Konstantin Belousov <kostikbel@gmail.com> To: Andriy Gapon <avg@FreeBSD.org> Cc: freebsd-fs@FreeBSD.org, zfs-devel@FreeBSD.org Subject: Re: zfs_rename: another zfs+vfs deadlock Message-ID: <20130719183500.GL5991@kib.kiev.ua> In-Reply-To: <51E9131F.1060707@FreeBSD.org> References: <51E679FD.3040306@FreeBSD.org> <20130717194557.GU5991@kib.kiev.ua> <51E9131F.1060707@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Vo48LVc30GAQuLuW Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 19, 2013 at 01:21:19PM +0300, Andriy Gapon wrote: > Also, I noticed that ufs_rename() checks for cross-device rename. Should all > filesystems do that or should that check belong to VFS layer (if not already > done there)? In principle yes, this sounds right. The only concern I see is layered filesystems like nullfs interaction with filesystems below the bypass. In other words, if any bypass provided the aggregation, this should be checked at the bypass layer too, in addition to the kern_renameat(). --Vo48LVc30GAQuLuW Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJR6YbTAAoJEJDCuSvBvK1BhGsQAJ7PmCb57BzSzDUJCwydMcr3 fOD9M8UwR1NKxAWboxmIbhqjL7bfzzzeNGTHwhPj6NqQZQeBg8Lq0lvoKEqKTT6Z lPl0acR7+V2IIwBD5wj7NBN6LkZvztXc92pUt7PmLOTi7sbNOC2r8eUIvEjyMjCC O1tN4/eZiKGOk3F6ityRNjn4h2JUkwAhfn85gMrJOQvOuxVvo/AgARcxdplZdZIv 1WzZFtfWYrRGCjNwxQ0w4qE2amZ5aJudcXJdU3qiKh8Ss9s9TkLV+ZDj6+kofng+ YCbVuQ3xD9N8EpG/bmYnZV4gzWuD4hDsHBYf3Ba3DE7rdJfek7/K4TRVLnQxBCa6 toTkJijznXFjM33qpjORaNwOvFu+dWnWKmzgDMs6Ky32eeRPPqQz7Fe8IgJMD1C9 JDMZbGHJ/wqCR+vNKGaGrlZO4EL/L54IhqY2i1r3f2/fyMKBVq5bxwIxs3c3F2sw qqF64vwsnfd1aeKUTtgCVVdaSRmrsG6hdjfgri4sMqX6GfjppAcqXf6sah9SzEcv ibNiMut4q8Z6lfb9xPwsYrzubmyelQilf111bB9g7VzZuEDsEfTJoSbIPWKXPikP 6tn29wD6+E04zvL0KrCB5QtMHUhoS1l6mfrEMPXrm2wDgGhI1zBGNIdvZfSE4XxG ToPDy+vHlxrf9lDmwM3J =ojft -----END PGP SIGNATURE----- --Vo48LVc30GAQuLuW--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130719183500.GL5991>