Date: Tue, 13 May 2014 00:46:20 +0200 From: Luigi Rizzo <rizzo@iet.unipi.it> To: bycn82 <bycn82@gmail.com> Cc: "freebsd-ipfw@freebsd.org" <freebsd-ipfw@freebsd.org>, Luigi Rizzo <rizzo@iet.unipi.it> Subject: Re: feature of `packet per second` Message-ID: <CA%2BhQ2%2BhNVn6VARG8njOw=6c-p=SP2s01kOECLPtGfmPJy8uPQg@mail.gmail.com> In-Reply-To: <5370FE5E.3000104@gmail.com> References: <5360F1F4.9060808@gmail.com> <5361105C.1040203@freebsd.org> <53611738.8010103@gmail.com> <CAOjFWZ4zRUmcjG-r--OqoGEWcSZoWhtTykgAAHzCjoEWsMVS9g@mail.gmail.com> <53611EB1.4000406@gmail.com> <CA%2BhQ2%2BhjjS=AXVdnaEdFOKY1DqiLuX9iP0gy3wo6FbwnEdq_Qw@mail.gmail.com> <5364E097.9020106@gmail.com> <CA%2BhQ2%2BgXC9uNdtH1VCGa%2Bs1dPNWjErC9qfgXmEnfQ4SQ6Rnz_g@mail.gmail.com> <536AD13B.6080907@gmail.com> <536AD941.9090102@gmail.com> <20140508073816.GB64368@onelab2.iet.unipi.it> <536BACA4.7010702@gmail.com> <5370FE5E.3000104@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 12, 2014 at 7:01 PM, bycn82 <bycn82@gmail.com> wrote: > On 5/9/14 0:11, bycn82 wrote: > ... > Done ,submitted. > > http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/189721 > can you clean up the formatting and style (including some gratuitous whitespace changes). Also there are several things to fix: - please use { } even for blocks with a single statement - please make count and duration 32 bit values. 16 bits are way too little for count, and there is no point to be stingy with count - count should not be incremented upon a 'DENY' or it could wrap (very risky for 16-bit values); cheers luigi
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BhQ2%2BhNVn6VARG8njOw=6c-p=SP2s01kOECLPtGfmPJy8uPQg>