Date: Tue, 11 Nov 2008 10:37:24 -1000 (HST) From: Jeff Roberson <jroberson@jroberson.net> To: "Murty, Ravi" <ravi.murty@intel.com> Cc: "freebsd-hackers@freebsd.org" <freebsd-hackers@freebsd.org>, jeff@FreeBSD.org, robert <robert@fledge.watson.org> Subject: Re: Typo in ULE in FreeBSD 8.0 -- that's not really a bug Message-ID: <20081111103600.G964@desktop> In-Reply-To: <6D5D25EA3941074EB7734E51B16687040AD02A77@orsmsx506.amr.corp.intel.com> References: <6D5D25EA3941074EB7734E51B16687040AD02A77@orsmsx506.amr.corp.intel.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, 10 Nov 2008, Murty, Ravi wrote: > Hello All, > > I have been playing with ULE in 8.0 and while staring at tdq_notify noticed an interesting (and what seems like a typo) problem. > The intention of the function is obvious, send an IPI to notify the remote CPU of some new piece of work. In the case where there is no IPI currently pending on the target CPU and this thread should be preempting what's running there, the code checks in td (passed in as a parameter) is the IDLE thread (TDF_IDLETD). If so, it checks the state and sees if idle is RUNNING and if so figures it will notice this new work and we don't really need to send an expensive IPI. However, why would td (parameter) ever be the IDLE thread? It almost seems like this check will always fail and we end up sending a hard IPI to the target CPU which works, but may not be needed. May be we wanted to use PCPU->curthread instead of td? Wow ravi, thanks. That's what it was at one point. It must've been refactored into brokenness. I'll fix and test soon. This has probably reduced the effectiveness of the mwait patch. Thanks, Jeff > > Thanks > Ravi > _______________________________________________ > freebsd-hackers@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-hackers > To unsubscribe, send any mail to "freebsd-hackers-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081111103600.G964>