Date: Sun, 22 Jul 2018 21:25:27 +0200 From: Hans Petter Selasky <hps@selasky.org> To: Ali Abdallah <aliovx@gmail.com>, freebsd-multimedia@freebsd.org Subject: Re: mixer_info modify_counter Message-ID: <76c1ca5f-7a33-51c7-af7b-6e1003b39333@selasky.org> In-Reply-To: <CAO3OKx8T--EuE3x9K-P4-v70hcnjfmeK%2B7_VTME5ZiVNYGixRw@mail.gmail.com> References: <CAO3OKx8T--EuE3x9K-P4-v70hcnjfmeK%2B7_VTME5ZiVNYGixRw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 07/22/18 20:08, Ali Abdallah wrote: > Hello, > > Any reason why the modify_counter bit of mixer_info is not incremented when > the mixer gets changed? > >>From sys/dev/sound/pcm/mixer.c:70 > /** > * Counter is incremented when applications change any of this > * mixer's controls. A change in value indicates that persistent > * mixer applications should update their displays. > */ > > But reading the code, it is clear that this is not the case, and the > counter remains 0. It is enough to call m->modify_counter++ in mixer_set on > line 327 for example to make persistent mixer applications work correctly. > Currently they have to poll for all mixer controls, even if no changes were > made to the mixer. > Hi, Can you create a PR and add a patch? --HPS
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?76c1ca5f-7a33-51c7-af7b-6e1003b39333>