Date: Mon, 16 May 2005 13:17:04 +0300 From: Giorgos Keramidas <keramida@freebsd.org> To: Bruce Evans <bde@zeta.org.au>, "David O'Brien" <obrien@freebsd.org> Cc: cvs-all@freebsd.org Subject: Re: cvs commit: src/usr.bin/top machine.c Message-ID: <20050516101704.GB676@orion.daedalusnetworks.priv> In-Reply-To: <20050516143822.D42751@delplex.bde.org> References: <200504161543.j3GFhclO075103@repoman.freebsd.org> <20050516001837.GA65506@dragon.NUXI.org> <20050516004059.GA15002@gothmog.gr> <20050516032743.GA89903@dragon.NUXI.org> <20050516143822.D42751@delplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2005-05-16 14:57, Bruce Evans <bde@zeta.org.au> wrote: >On Sun, 15 May 2005, David O'Brien wrote: >>On Mon, May 16, 2005 at 03:40:59AM +0300, Giorgos Keramidas wrote: >>>On 2005-05-15 17:18, David O'Brien <obrien@FreeBSD.org> wrote: >>>> >>>>Please back machine.c back to revsion 1.69, ASAP. >>>>The current top is redicious: >>..snip.. >>>Your USERNAME column is too wide (12 columns). Do you happen to have >>>very long names? >> >> The dovecot port adds a the 'dovecot-auth' user. The top(1) code >> supports 13 character usernames on SMP systems and 15 on UP systems. >> Your rev 1.70-1.71 changes failed to take that into account. > > Another bug in top is that it expands the USERNAME column to have enough > space for the longest user name (clipped to 13 or 15 characters), even > when the user(s) with the longest name have never run any processes. > > Another bug in at last old versions of top (machine.c 1.51) is that this > support is broken if there is actually a user name of maximal length, due > to essentially the same bug that brought this thread back to life: the > header is not properly truncated; I have a local patch that already does this. Care to have a look and tell me if it's ok to commit the header timming diff? >>> If that is true, would it be ok to wait 1-2 days until I have a >>> machine.c version that prints USERNAME using only 8 columns instead >>> of using arbitrarily long columns, like now? >> >> I don't know why to wait 1-2 days. I made the change in 1 minute. >> Or is there debate if that change will be acceptable? If there isn't >> a debate about it, let me know and I'll commit this diff. > > It is easy to add more bugs in 1 minute. Exactly :-)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050516101704.GB676>