Date: Tue, 14 Jun 2011 23:30:15 +0300 From: Alexander Motin <mav@FreeBSD.org> To: Rick van der Zwet <info@rickvanderzwet.nl> Cc: FreeBSD-Current <freebsd-current@freebsd.org> Subject: Re: ATA_PERIODIC_POLL on ATA_I82801HBM_S1 causes lockups Message-ID: <4DF7C4D7.9000006@FreeBSD.org> In-Reply-To: <BANLkTi=wL_OrEuF5xdwQuUK%2Bd6NHxK3fnw@mail.gmail.com> References: <mailpost.1308032279.3200006.77402.mailing.freebsd.current@FreeBSD.cs.nctu.edu.tw> <4DF76176.7030207@FreeBSD.org> <BANLkTi=wL_OrEuF5xdwQuUK%2Bd6NHxK3fnw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Rick van der Zwet wrote: > On 14 June 2011 15:26, Alexander Motin <mav@freebsd.org> wrote: >> Rick van der Zwet wrote: >>> The ICH8M found in the MacBookPro4,1 has an known issue [1] which >>> locks up when enabling the periodic poll using sidpr (introduced a >>> ``little'' while ago in r214016), making it impossible to boot. >>> >>> Attached patch disables the polling and thus fixes the issue. >>> >>> Br. /Rick >>> [1] http://www.spinics.net/lists/linux-ide/msg23487.html >> Thank you for reminder, but your patch is not exactly right. Could you >> test this one: >> >> Index: ata-intel.c >> =================================================================== >> --- ata-intel.c (revision 223019) >> +++ ata-intel.c (working copy) >> @@ -288,7 +288,9 @@ >> ATA_OUTL(ctlr->r_res2, 0x0C, >> ATA_INL(ctlr->r_res2, 0x0C) | 0xf); >> } >> - } else { >> + /* Skip BAR(5) on ICH8M Apples, system locks up on access. */ >> + } else if (ctlr->chip->chipid != ATA_I82801HBM_S1 || >> + pci_get_subvendor(dev) != 0x106b) { >> ctlr->r_type2 = SYS_RES_IOPORT; >> ctlr->r_rid2 = PCIR_BAR(5); >> ctlr->r_res2 = bus_alloc_resource_any(dev, ctlr->r_type2, > > Works like a charm. Thank you. Committed at r223097. -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DF7C4D7.9000006>