Date: Fri, 18 Jan 2013 15:26:24 +0200 From: Alexander Motin <mav@FreeBSD.org> To: Jaakko Heinonen <jh@FreeBSD.org> Cc: "Justin T. Gibbs" <gibbs@FreeBSD.org>, satan@ukr.net, Gleb Smirnoff <glebius@FreeBSD.org>, freebsd-current@FreeBSD.org Subject: Re: panic after r244584 Message-ID: <50F94D80.7000809@FreeBSD.org> In-Reply-To: <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi> References: <20130118073600.GA70874@hell.ukr.net> <20130118094424.GD2331@FreeBSD.org> <50F93165.60809@FreeBSD.org> <20130118113934.GA60441@hell.ukr.net> <50F9357F.8040109@FreeBSD.org> <20130118131954.GA3868@a91-153-116-96.elisa-laajakaista.fi>
next in thread | previous in thread | raw e-mail | index | archive | help
On 18.01.2013 15:19, Jaakko Heinonen wrote: > On 2013-01-18, Alexander Motin wrote: >>> AM> > V> panic: make_dev_alias_v: bad si_name (error=22 si_name=enc@n5003048000bab37d/tpe0/slot@1/elmdesc@Slot 01/pass7) > >>> AM> The panic is triggered by the check added by the recent r244584 change. >>> AM> The space in device name came from the enclosure device, and I guess it >>> AM> may be quite often situation. Using human readable name supposed to help >>> AM> system administrators, but with spaces banned that may be a problem. >>> >>> That's was not created by human, it was generated (I think so) by system. >> >> These strings are flashed into enclosure firmware by manufacturer. > > You can't rely on that any string can be safely used as a device name > even if spaces were allowed. Consider for example duplicate names and > "../". > > Where these names are generated? The original report didn't contain a > backtrace. At cam/scsi/ses_set_physpath.c ses_set_physpath(). Duplicate names are impossible there, as previous name components are unique. Special characters haven't yet seen, but I think theoretically possible. Interesting what Solaris does in such cases, mangles them somehow or removes completely? -- Alexander Motin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?50F94D80.7000809>