Skip site navigation (1)Skip section navigation (2)
Date:      7 Dec 2009 08:36:33 -0200
From:      Renato Botelho <garga@FreeBSD.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        ntarmos@cs.uoi.gr
Subject:   ports/141244: [PATCH] x11-wm/awesome: Fix awful bug introduced in 3.4
Message-ID:  <20091207103633.28996.qmail@botelhor.bplab.local>
Resent-Message-ID: <200912071040.nB7Ae2cU040875@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         141244
>Category:       ports
>Synopsis:       [PATCH] x11-wm/awesome: Fix awful bug introduced in 3.4
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Mon Dec 07 10:40:02 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator:     Renato Botelho
>Release:        FreeBSD 9.0-CURRENT i386
>Organization:
FreeBSD.org
>Environment:
System: FreeBSD botelhor.bplab.local 9.0-CURRENT FreeBSD 9.0-CURRENT #99 r199996: Tue Dec  1 16:07:53
>Description:
A regression was introduced on 3.4 version, you can show a more detailed
description at [1], i got the patch there.

[1] - http://awesome.naquadah.org/bugs/index.php?do=details&task_id=664

Added file(s):
- files/patch-lib__awful__rules.lua.in
- files/patch-lib__awful__tag.lua.in

Port maintainer (ntarmos@cs.uoi.gr) is cc'd.

Generated with FreeBSD Port Tools 0.99
>How-To-Repeat:
>Fix:

--- awesome-3.4.2_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/x11-wm/awesome/Makefile,v
retrieving revision 1.36
diff -u -u -r1.36 Makefile
--- Makefile	27 Nov 2009 09:56:14 -0000	1.36
+++ Makefile	7 Dec 2009 10:35:08 -0000
@@ -7,6 +7,7 @@
 
 PORTNAME=	awesome
 PORTVERSION=	3.4.2
+PORTREVISION=	1
 CATEGORIES=	x11-wm
 MASTER_SITES=	http://awesome.naquadah.org/download/ \
 		http://redundancy.redundancy.org/mirror/
Index: files/patch-lib__awful__rules.lua.in
===================================================================
RCS file: files/patch-lib__awful__rules.lua.in
diff -N files/patch-lib__awful__rules.lua.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-lib__awful__rules.lua.in	7 Dec 2009 10:35:08 -0000
@@ -0,0 +1,23 @@
+--- lib/awful/rules.lua.in
++++ lib/awful/rules.lua.in
+@@ -89,7 +89,9 @@ end
+ 
+ --- Apply rules to a client.
+ -- @param c The client.
+-function apply(c)
++-- @param startup Executed at startup ? (optional, default is false)
++function apply(c, startup)
++    startup = startup or false
+     local props = {}
+     local callbacks = {}
+     for _, entry in ipairs(rules) do
+@@ -129,6 +131,9 @@ function apply(c)
+         callback(c)
+     end
+ 
++    -- Apply tags.
++    atag.withcurrent(c, startup)
++
+     -- Do this at last so we do not erase things done by the focus
+     -- signal.
+     if props.focus then
Index: files/patch-lib__awful__tag.lua.in
===================================================================
RCS file: files/patch-lib__awful__tag.lua.in
diff -N files/patch-lib__awful__tag.lua.in
--- /dev/null	1 Jan 1970 00:00:00 -0000
+++ files/patch-lib__awful__tag.lua.in	7 Dec 2009 10:35:08 -0000
@@ -0,0 +1,10 @@
+--- lib/awful/tag.lua.in
++++ lib/awful/tag.lua.in
+@@ -374,7 +374,6 @@ capi.client.add_signal("manage", function(c, startup)
+             c.screen = capi.mouse.screen
+         end
+     end
+-    withcurrent(c, startup)
+     c:add_signal("property::screen", withcurrent)
+ end)
+ 
--- awesome-3.4.2_1.patch ends here ---

>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20091207103633.28996.qmail>