Date: Sun, 15 Feb 2015 21:53:12 +0300 From: Gleb Smirnoff <glebius@FreeBSD.org> To: "Ranjan1018 ." <214748mv@gmail.com> Cc: Konstantin Belousov <kostikbel@gmail.com>, Adrian Chadd <adrian@freebsd.org>, FreeBSD CURRENT <freebsd-current@freebsd.org> Subject: Re: Suspend/resume on i915 stop working between r278348 and r278741. Message-ID: <20150215185311.GP15484@FreeBSD.org> In-Reply-To: <CACyC=qb1z3fC8=XeSZDLf8usWR_BUzL5XJ1oobqrQ2-nSq5CQQ@mail.gmail.com> References: <CACyC=qajpScpmYH6mEtUh9eopJMW_de34_GPYjfsuLxr8fy2nQ@mail.gmail.com> <CAJ-VmonomEoBO2moxSeGcqokBFZAzMO8HbSNmKChYcpkEH7e9Q@mail.gmail.com> <CACyC=qanWQu_v011A5OcTWLPw-t2weoBrQRkM_1vHKQjkxQMDA@mail.gmail.com> <20150215151141.GB34251@kib.kiev.ua> <CACyC=qb1z3fC8=XeSZDLf8usWR_BUzL5XJ1oobqrQ2-nSq5CQQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Feb 15, 2015 at 07:45:44PM +0100, Ranjan1018 . wrote:
R> > On Sun, Feb 15, 2015 at 03:37:17PM +0100, Ranjan1018 . wrote:
R> > > Hi,
R> > > the bug was introduced in r278473. Suspend/resume works again if I
R> > disable
R> > > the x2APIC support with hw.x2apic_enable=0 in /boot/loader.conf, tested
R> > in
R> > > r278473 and r278741.
R> >
R> > So how it is related to i915 ?
R> >
R> > Sorry, just my guess.
R>
R>
R> > Try the patch.
R> >
R> > diff --git a/sys/x86/x86/local_apic.c b/sys/x86/x86/local_apic.c
R> > index 1809fa6..c8ea35e 100644
R> > --- a/sys/x86/x86/local_apic.c
R> > +++ b/sys/x86/x86/local_apic.c
R> > @@ -541,6 +541,9 @@ native_lapic_setup(int boot)
R> >
R> > saveintr = intr_disable();
R> >
R> > + if (!boot && x2apic_mode)
R> > + native_lapic_enable_x2apic();
R> > +
R> > la = &lapics[lapic_id()];
R> > KASSERT(la->la_present, ("missing APIC structure"));
R> > maxlvt = (lapic_read32(LAPIC_VERSION) & APIC_VER_MAXLVT) >>
R> > MAXLVTSHIFT;
R> >
R>
R> Unfortunately does not work for me. Tested with r278803.
Me neither.
Also, I noticed that in my case the suspend sequence is also behaving
differently from pre-x2apic kernel.
With new kernel, suspend sequence doesn't switch from X to vt(4), screen
switches to black directly from X. So, probably the resume isn't broken
at all, instead suspend is broken: it puts machine in a state that can't
be resumed.
--
Totus tuus, Glebius.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150215185311.GP15484>