Date: Mon, 9 Apr 2018 09:07:31 -0500 From: Kyle Evans <kevans@freebsd.org> To: Kyle Evans <kevans@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r332327 - head/sys/arm/allwinner Message-ID: <CACNAnaGNea6wUp-YtX4jg3A1qVG3OA_XO3h_MUj96DwdxmxK4A@mail.gmail.com> In-Reply-To: <201804091405.w39E5in8049357@repo.freebsd.org> References: <201804091405.w39E5in8049357@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Apr 9, 2018 at 9:05 AM, Kyle Evans <kevans@freebsd.org> wrote: > Author: kevans > Date: Mon Apr 9 14:05:43 2018 > New Revision: 332327 > URL: https://svnweb.freebsd.org/changeset/base/332327 > > Log: > if_awg: Add support for allwinner,{tx,rx}-delay-ps bindings > > Split out delay parsing into a separate function; we'll support both > {tx,rx}-delay as well as the new versions. > > While here, validate that they're within the expected range and fail to > attach if they are not. Assuming that we can clamp the delay is a bad idea > that might result in a non-working awg anyways, so we'll fail early to make > it easier to catch. > > This version also unsets the tx and rx delay registers unconditionally and > then sets them if we read a non-zero delay. These delay properties should > default to 0 if not specified, as declared in the binding documentation. > Presumably the delays will be set via hardware configuration if they're not > explicitly set in FDT. > Ugh, I dropped these: Reviewed by: manu Differential Revision: https://reviews.freebsd.org/D15008
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACNAnaGNea6wUp-YtX4jg3A1qVG3OA_XO3h_MUj96DwdxmxK4A>