Date: Tue, 19 Jun 2007 19:03:44 -0700 From: Alfred Perlstein <alfred@freebsd.org> To: Maxim Sobolev <sobomax@FreeBSD.org> Cc: cvs-src@FreeBSD.org, Pav Lucistnik <pav@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: src/usr.sbin/pkg_install/lib deps.c Message-ID: <20070620020344.GI98795@elvis.mu.org> In-Reply-To: <4678663E.2060204@FreeBSD.org> References: <200706182249.l5IMnE4H099470@repoman.freebsd.org> <467863E0.2040906@FreeBSD.org> <20070619232125.GA750@rot13.obsecurity.org> <4678653B.8070409@FreeBSD.org> <20070619232451.GA872@rot13.obsecurity.org> <4678663E.2060204@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
* Maxim Sobolev <sobomax@FreeBSD.org> [070619 16:28] wrote: > Kris Kennaway wrote: > >On Tue, Jun 19, 2007 at 04:22:35PM -0700, Maxim Sobolev wrote: > >>Kris Kennaway wrote: > >>>On Tue, Jun 19, 2007 at 04:16:48PM -0700, Maxim Sobolev wrote: > >>>>I have made the following patch to bring style(9) back and make code > >>>>more readable. Do you guys want to run it on bento or could I just > >>>>check it in? > >>>> > >>>>http://sobomax.homeunix.org/~sobomax/deps.c.diff > >>>Is md5 checksum the same before/after? > >>Well, it has some trivial non-whitespace changes. > > > >whitespace in source does not show up in the binary. > > Please re-read my message. It has NON-whitespace changes as well. > > -Maxim lol.. he means does the resulting binary have the same md5? if it's just style changes, then it should. also, you missed a non-style conformant function. void list_deps(const char *pkgname, char **pkgs, char *listed, that should be: void list_deps -- - Alfred Perlstein
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070620020344.GI98795>