Date: Fri, 28 Nov 2014 16:29:42 +0300 From: Eygene Ryabinkin <rea@freebsd.org> To: kib@FreeBSD.org Cc: freebsd-current@FreeBSD.org Subject: [CFR][PATCH] drm2: don't assume that dev->driver->max_ioctl > *dev->driver->compat_ioctls_nr Message-ID: <xmwjC4AQ874ym1oFCGAsPn1EJkI@1d%2BaJAniZP50FCDdGj54nd51%2Bks>
next in thread | raw e-mail | index | archive | help
--185D1s7FREAUfc0L Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Konstantin, *, good day. I noticed that the current ioctl processing code for drm2 implicitely assumes that the number of native ioctls is higher than that of 32-bit compat ones, so it immediately gives EINVAL when nr >=3D dev->driver->max_ioctl. Seems that in future such assumption may not be true in all cases. This can be fixed with the following patch: http://codelabs.ru/fbsd/patches/drm2/drm_drv-untangle-32bit-compat.diff Any thoughts on it? Thanks. --=20 Eygene Ryabinkin ,,,^..^,,, [ Life's unfair - but root password helps! | codelabs.ru ] [ 82FE 06BC D497 C0DE 49EC 4FF0 16AF 9EAE 8152 ECFB | freebsd.org ] --185D1s7FREAUfc0L Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iL4EABEKAGYFAlR4eMZfFIAAAAAALgAoaXNzdWVyLWZwckBub3RhdGlvbnMub3Bl bnBncC5maWZ0aGhvcnNlbWFuLm5ldDgyRkUwNkJDRDQ5N0MwREU0OUVDNEZGMDE2 QUY5RUFFODE1MkVDRkIACgkQFq+eroFS7PtkwQD/cF22KnZ/mqgwaQDs1TSrJehP FKGerfR5mxp2X+zN4u4A/iZAnQh/qBG0DezuHdObMKrsuEJYfv2teeo7YJPR1L0F =VLbF -----END PGP SIGNATURE----- --185D1s7FREAUfc0L--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?xmwjC4AQ874ym1oFCGAsPn1EJkI>