Date: Tue, 25 Nov 2008 11:36:47 -0700 (MST) From: "M. Warner Losh" <imp@bsdimp.com> To: stas@freebsd.org Cc: arm@freebsd.org Subject: Re: Code review request: boards on AT91 Message-ID: <20081125.113647.1346821827.imp@bsdimp.com> In-Reply-To: <20081125212409.3dab8178.stas@FreeBSD.org> References: <20081125.104452.535842403.imp@bsdimp.com> <20081125212409.3dab8178.stas@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message: <20081125212409.3dab8178.stas@FreeBSD.org>
Stanislav Sedov <stas@FreeBSD.org> writes:
: -----BEGIN PGP SIGNED MESSAGE-----
: Hash: SHA1
:
: On Tue, 25 Nov 2008 10:44:52 -0700 (MST)
: "M. Warner Losh" <imp@bsdimp.com> mentioned:
:
: > I'm trying a little experiment. I'm moving the board support for the
: > different sets of boards we support to their own file. This is the
: > first step in moving to supporting multiple boards more easily.
: > There's a number of gross hacks to make this work now in at91 land,
: > and I'd like to clean them up. The mv port is much cleaner, but we
: > still likely need some way to identify boards and get the right board
: > support code called. In Linux land, all ARM boot loaders are expected
: > to pass in a machine type, which is used to do the multiplexing.
: > Something similar in FreeBSD would be useful (and not just for ARM).
: >
: > Eventually, I'd like to see more common code between the different arm
: > variants. This will ease porting efforts as well as make the code
: > more robust.
:
: I think we could pass the board type via a special kenv variable
: for now. I think it will work fine and applicable to all supported
: architectures. We could probably reuse board type constants that Linux
: kernel uses.
Right now that's passed in from uboot and other loaders in I think r3,
but I'd have to go look at some other code to be sure.
: > If anybody wants me to write up where I'm going with this, or answer
: > any question, please feel free to ask. Also, comments would be nice.
: >
: > Warner
: >
:
: The code looks OK to me. I have only one question: why you have added
: a commented out AT91_BOARD_KB920X option to the default kernel config?
: Is it just a leftover?
Leftover. Forgot the basics of kernel config for a moment.
Warner
: - --
: Stanislav Sedov
: ST4096-RIPE
: -----BEGIN PGP SIGNATURE-----
:
: iEYEARECAAYFAkksQs0ACgkQK/VZk+smlYFntwCfbHv6JJmTjzI6GL5Ra1k4nA2a
: nGAAn06uoskVCyZ2E5eFkTtQQ7eXnmz0
: =xuFv
: -----END PGP SIGNATURE-----
:
:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20081125.113647.1346821827.imp>