Date: Fri, 18 Feb 2005 15:51:01 -0500 (EST) From: Daniel Eischen <deischen@freebsd.org> To: Craig Rodrigues <rodrigc@crodrigues.org> Cc: freebsd-threads@freebsd.org Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing Message-ID: <Pine.GSO.4.43.0502181549040.16964-100000@sea.ntplx.net> In-Reply-To: <200502182040.j1IKeKG6019752@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, 18 Feb 2005, Craig Rodrigues wrote: > The following reply was made to PR threads/76938; it has been noted by GNATS. > > From: Craig Rodrigues <rodrigc@crodrigues.org> > To: freebsd-gnats-submit@freebsd.org > Cc: tmclaugh@sdf.lonestar.org, freebsd-standards@freebsd.org > Subject: Re: threads/76938: include/unistd.h: ttyname_r prototype missing > Date: Fri, 18 Feb 2005 15:30:45 -0500 > > The following patch exports ttyname_r() from <unistd.h> and makes it > conform to the Single Unix Specification: > http://www.opengroup.org/onlinepubs/009695399/functions/ttyname.html > > Can someone with a commit bit take a look at it? Style: all returns should be "return (foo)", not "return foo". This may also cause an ABI change since ttyname_r use to return (char *). I'm not sure of the impact though 'cause it was never in a header file. -- DE
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.GSO.4.43.0502181549040.16964-100000>