Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 4 May 2013 05:06:36 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Baptiste Daroussin <bapt@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r317243 - head/deskutils/menumaker
Message-ID:  <20130504050636.GA54091@FreeBSD.org>
In-Reply-To: <201305032040.r43KeNIb027043@svn.freebsd.org>
References:  <201305032040.r43KeNIb027043@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, May 03, 2013 at 08:40:23PM +0000, Baptiste Daroussin wrote:
> New Revision: 317243
> URL: http://svnweb.freebsd.org/changeset/ports/317243
> 
> Log:
>   Fix build with bmake
> 
> @@ -14,6 +10,7 @@ MAINTAINER=	ports@FreeBSD.org
>  COMMENT=	Menu generator for X Window Managers and desktop environments
>  
>  USE_PYTHON=	yes
> +USE_GMAKE=	yes

Since you decided not to surround it with bmake-specific conditional this
time, I think it would be nice to add a comment instead, e.g.:

    USE_GMAKE=yes			# fails with bmake(1)

I usually try to check periodically why some ports need gmake(1); it would
make it easier for me with such comments, thanks!

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130504050636.GA54091>