Date: Thu, 03 Oct 1996 00:08:34 -0700 From: "Jordan K. Hubbard" <jkh@time.cdrom.com> To: sos@FreeBSD.org Cc: peter@spinner.DIALix.COM (Peter Wemm), jkh@freefall.freebsd.org, CVS-committers@freefall.freebsd.org, cvs-all@freefall.freebsd.org, cvs-sys@freefall.freebsd.org Subject: Re: cvs commit: src/sys/i386/isa syscons.c Message-ID: <10555.844326514@time.cdrom.com> In-Reply-To: Your message of "Thu, 03 Oct 1996 08:57:42 %2B0200." <199610030657.IAA07715@ra.dkuug.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
> Excuse me, but I tend to think that the compiler should be fixed here... Fixed how? It's not broken. :-) We're compiling syscons.c with -Wunused and gcc, faithfully according to instruction, is warning you about unused variables. __unused sounds kinda gross, but it's still worlds better than the /* WUNUSED*/ comments which were "magically understood" by lint, along with /* NOTREACHED */. It's just not possible to make the verifier flag these cases in a "DWIM" fashion, since an intentional omission is indistinguishable from a bug at that level, so you either don't ask for -Wunused warnings or you give the compiler hints. Seems reasonable to me! Jordan
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?10555.844326514>