Date: Mon, 7 Oct 2019 02:36:42 +0000 (UTC) From: Justin Hibbits <jhibbits@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r353158 - head/sys/powerpc/aim Message-ID: <201910070236.x972agwN039458@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhibbits Date: Mon Oct 7 02:36:42 2019 New Revision: 353158 URL: https://svnweb.freebsd.org/changeset/base/353158 Log: powerpc64/pmap: Fix release order to match lock order in moea64_enter() Page PV lock is always taken first, so should be released last. This also (trivially) shortens the hold time of the pmap lock. Submitted by: mjg Modified: head/sys/powerpc/aim/mmu_oea64.c Modified: head/sys/powerpc/aim/mmu_oea64.c ============================================================================== --- head/sys/powerpc/aim/mmu_oea64.c Mon Oct 7 01:03:14 2019 (r353157) +++ head/sys/powerpc/aim/mmu_oea64.c Mon Oct 7 02:36:42 2019 (r353158) @@ -1453,8 +1453,8 @@ moea64_enter(mmu_t mmu, pmap_t pmap, vm_offset_t va, v moea64_pvo_enter(mmu, pvo, pvo_head, NULL); } } - PV_PAGE_UNLOCK(m); PMAP_UNLOCK(pmap); + PV_PAGE_UNLOCK(m); /* Free any dead pages */ if (error == EEXIST) {
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201910070236.x972agwN039458>