Date: Mon, 11 Mar 2019 14:17:48 -0400 From: Jung-uk Kim <jkim@FreeBSD.org> To: Ravi Pokala <rpokala@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344982 - head/sys/x86/isa Message-ID: <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org> In-Reply-To: <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe Content-Type: multipart/mixed; boundary="ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m"; protected-headers="v1" From: Jung-uk Kim <jkim@FreeBSD.org> To: Ravi Pokala <rpokala@freebsd.org>, Vladimir Kondratyev <wulf@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <c7ad6dd0-5789-5e47-34c5-b33260f9845c@FreeBSD.org> Subject: Re: svn commit: r344982 - head/sys/x86/isa References: <201903102019.x2AKJiJY029807@repo.freebsd.org> <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> In-Reply-To: <00F61A40-C128-4F75-A45F-A6CECBB791C2@panasas.com> --ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m Content-Type: multipart/mixed; boundary="------------24835374B76989557A313568" Content-Language: en-US This is a multi-part message in MIME format. --------------24835374B76989557A313568 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 19. 3. 11., Ravi Pokala wrote: > -----Original Message----- > From: <owner-src-committers@freebsd.org> on behalf of Vladimir Kondraty= ev <wulf@FreeBSD.org> > Date: 2019-03-10, Sunday at 13:19 > To: <src-committers@freebsd.org>, <svn-src-all@freebsd.org>, <svn-src-h= ead@freebsd.org> > Subject: svn commit: r344982 - head/sys/x86/isa >=20 >> Author: wulf >> Date: Sun Mar 10 20:19:43 2019 >> New Revision: 344982 >> URL: https://svnweb.freebsd.org/changeset/base/344982 >> >> Log: >> atrtc(4): install ACPI RTC/CMOS operation region handler >=20 > Hi Vladimir, >=20 > This appears to have broken all the various LINT kernels for amd64 and = i386: >=20 > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: er= ror: use of undeclared identifier '_AcpiModuleName' > ACPI_FUNCTION_TRACE((char *)(uintptr_t)__func__); > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:402:39: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/x86/isa/atrtc.c:321:2: er= ror: use of undeclared identifier '_COMPONENT' > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:480:18: note: expanded from macro 'ACPI_FUNCTION_TRACE' > AcpiUtTrace (ACPI_DEBUG_PARAMETERS) > ^ > /usr/home/rpokala/freebsd/clean/base/head/sys/contrib/dev/acpica/includ= e/acoutput.h:402:56: note: expanded from macro 'ACPI_DEBUG_PARAMETERS' > __LINE__, ACPI_GET_FUNCTION_NAME, _AcpiModuleName, _COMPONENT > ^ > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >=20 > That same pattern of errors is noted for lines 321, 362, and 386. >=20 > Please take a look at your earliest convenience. Please try the attached patch. Jung-uk Kim --------------24835374B76989557A313568 Content-Type: text/x-patch; name="atrtc.diff" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="atrtc.diff" Index: sys/x86/isa/atrtc.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- sys/x86/isa/atrtc.c (revision 345013) +++ sys/x86/isa/atrtc.c (working copy) @@ -83,6 +83,11 @@ static int rtc_reg =3D -1; static u_char rtc_statusa =3D RTCSA_DIVIDER | RTCSA_NOPROF; static u_char rtc_statusb =3D RTCSB_24HR; =20 +#ifdef DEV_ACPI +#define _COMPONENT ACPI_TIMER +ACPI_MODULE_NAME("ATRTC") +#endif + /* * RTC support routines */ --------------24835374B76989557A313568-- --ZzUiJPbxQg2h1sVl3OTdwnTXTx7lB2G6m-- --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEl1bqgKaRyqfWXu/CfJ+WJvzb8UYFAlyGplMACgkQfJ+WJvzb 8UZiHwf+KnHjbmgKU62C0QR0b31gWjXKHvvVcuo0gCSwdMGN6f/gn4GHyumJkoWa lExeZFQ8Sqj+Cqz21S63h/0jAwpLuZ+YF5rClaAhvue/kmcP829R9apS45yovESN cRuQ/JLj+b4PFsd611bNU0XMsU7eFKyUFAioxO0YRmFsOKzQh13gdR8oneSECXUQ logKKIhq3GfZWk34cYHaLoj4/prjLIh2f/LyKk6YiyC8dZtoy3U6rYnjAxygbaFB APVWxdJiwkuepbAZOn6prgWvB3w0JqyYOT6h39WdHmEBsiZA4tpnLXlLCkzlMp79 IBfsfaWQc0cRNptRLJzFWsprA44hig== =cFVs -----END PGP SIGNATURE----- --8hW1Bii9Yy2oRgPkvBN6DR9CYkMVJ9WVe--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c7ad6dd0-5789-5e47-34c5-b33260f9845c>