Date: Sun, 30 Jun 2002 11:54:20 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Luigi Rizzo <luigi@FreeBSD.ORG> Cc: cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/i386/isa clock.c src/sys/i386/include param.h src/sys/conf options.i386 Message-ID: <62778.1025430860@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 30 Jun 2002 02:05:10 PDT." <20020630020510.B79625@iguana.icir.org>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <20020630020510.B79625@iguana.icir.org>, Luigi Rizzo writes: >On Sun, Jun 30, 2002 at 10:25:25AM +0200, Poul-Henning Kamp wrote: >... >> >> > If someone feels like porting this code to -current, it might be >> >> > a good idea to keep separate per-cpu buffers to avoid the cost >> >> > of protecting against concurrent accesses. >> >> The please explain the "If someone feels like..." to me. It certainly >> reads as if you don't plan to... > >Not in the next 35 seconds, but just because i want first to hear >feedback from our friends in the US. If you want feedback on the idea, you should have posted the patch to arch@ and similar places, not committed it to the tree, and _never_ committed it directly to -stable. >But otherwise, you read too much in that sentence. Why should I >even spend time thinking on how to do it in -current if I had no >plans to commit it ? Well, It could be because you are doing your work in -stable instead of -current ? It could also be because you tried to do the same thing with your polling code ? :-) Quite frankly, I think the stuff you committed may not belong in either of current or stable, it seems of far too limited scope (only i386, no smp etc etc) to me to be generally useful. But no matter its actual qualities or in this case lack thereof, it certainly does not belong in -stable until it has proven its worth in -current. Please back it out. -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?62778.1025430860>