Date: Fri, 23 Apr 2021 23:53:23 +0200 From: Matthias Andree <mandree@FreeBSD.org> To: Gleb Popov <arrowd@freebsd.org>, Mathieu Arnold <mat@freebsd.org> Cc: ports-committers <ports-committers@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5b7c17856512 - main - git hooks: Rework authorship instructions. Message-ID: <c7e6049b-9f4e-d63f-da12-00dbc3c54ddd@FreeBSD.org> In-Reply-To: <CALH631kMq18zTnh8niedOxpQSxcdp5xX-wtVO7ccSV7TR74mdg@mail.gmail.com> References: <YIFK/tIpcfqWTWVh@FreeBSD.org> <FB32E75F-9AF0-41C2-9EE1-B10D931DECD0@freebsd.org> <20210422101616.c3i7dn6gfm6hhner@aching.in.mat.cc> <YIFTYpPMe43y6tU9@FreeBSD.org> <20210422104914.d3kwtrwl2jovwvu2@aching.in.mat.cc> <CALH631kMq18zTnh8niedOxpQSxcdp5xX-wtVO7ccSV7TR74mdg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
Am 22.04.21 um 13:23 schrieb Gleb Popov: > > > On Thu, Apr 22, 2021 at 1:49 PM Mathieu Arnold <mat@freebsd.org > <mailto:mat@freebsd.org>> wrote: > > Then you are misusing Submitted by. Submitted by was supposed to be > used when you committed something that was, well, submitted by someone > else. If the work is yours, and that you based your work on someone > else's, then, it is not submitted by them. > > -- > Mathieu Arnold > > > In the past I sometimes used "Submitted by (someguy, initial patch)" and > still think it is a good thing. > > Creating an initial port is not only about typing something in the text > editor, but also figuring out how to build the software. This is also > quite an effort sometimes, invisible for the commiter, and I believe it > should be credited. I concur, and I will pull out something that was proposed between the lines in this thread already: 1. use the original patch and commit with --author attribution. Do not push yet. 2. polish, touch-up, refine it as committer or integrator, and commit that with author = committer 3. git pull --rebase --autostash, git push 4. optionally, MFH
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?c7e6049b-9f4e-d63f-da12-00dbc3c54ddd>