Date: Wed, 12 May 2010 15:15:56 +0300 From: Kostik Belousov <kostikbel@gmail.com> To: Dag-Erling Sm??rgrav <des@des.no> Cc: freebsd-current@freebsd.org, Ivan Voras <ivoras@freebsd.org> Subject: Re: HEADS UP: 64-bit quotas going in to head today Message-ID: <20100512121556.GA83316@deviant.kiev.zoral.com.ua> In-Reply-To: <86hbmduxzh.fsf@ds4.des.no> References: <201005070036.o470a3pl044330@chez.mckusick.com> <hs0m1e$ovp$1@dough.gmane.org> <86d3x24a43.fsf@ds4.des.no> <20100511193333.GW83316@deviant.kiev.zoral.com.ua> <86hbmduxzh.fsf@ds4.des.no>
next in thread | previous in thread | raw e-mail | index | archive | help
--bgVZo3zXaTQrZhjg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 12, 2010 at 02:05:06PM +0200, Dag-Erling Sm??rgrav wrote: > Kostik Belousov <kostikbel@gmail.com> writes: > > Dag-Erling Sm??rgrav <des@des.no> writes: > > > It adds quite a bit of code to pretty much every UFS VOP. > > No, it does not. Essentially, it adds one or two function calls per > > vop that allocate or deallocate blocks or inodes, and the function > > bodies verify two array members and return if those are NULL. >=20 > Read ufs_vnops.c, count the number of #ifdef QUOTA. There's quite a bit > more than just "one or two function calls per vop". Quite a bit of > locking going on, too, e.g. in ufs_accessx(). I did read the code when I fine-locked quotas. I stand on my position that it is one or two accounting calls per vop that do nothing in case of disabled quotas. ufs_accessx() path is seldomly executed. You mostly have to open file read-write if you are going to modify inode, and vn_open_cred() already uses exclusive locking there. It is calls like chmod(2) that are catched at this point, performing the operation by path instead of fd. --bgVZo3zXaTQrZhjg Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (FreeBSD) iEYEARECAAYFAkvqm/wACgkQC3+MBN1Mb4hPCwCg2q0r2r1bGjAQoUbQ9ZNGPo1L HGkAn0q4cojd53TaWHG/+7+Ixnekka2b =0qcU -----END PGP SIGNATURE----- --bgVZo3zXaTQrZhjg--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100512121556.GA83316>