Date: Thu, 29 Jan 1998 09:34:01 -0500 From: Matt Thomas <matt@3am-software.com> To: Stephen McKay <syssgm@dtir.qld.gov.au> Cc: freebsd-current@FreeBSD.ORG Subject: Re: PATCH: if_de.c #ifdef based version encoding Message-ID: <199801291434.JAA19360@tecumseh.altavista-software.com> In-Reply-To: <199801291401.AAA12197@troll.dtir.qld.gov.au> References: <199801280243.VAA17410@tecumseh.altavista-software.com> <34CE4438.15FB7483@whistle.com> <199801271101.DAA25275@implode.root.com> <34CE4438.15FB7483@whistle.com> <199801280243.VAA17410@tecumseh.altavista-software.com>
next in thread | previous in thread | raw e-mail | index | archive | help
At 09:01 AM 1/29/98 , Stephen McKay wrote: >On Tuesday, 27th January 1998, Matt Thomas wrote: > >[ Regarding version conditionals in if_de.c ] >>>Making Matt's life difficult would be counterproductive, but these version >>>tests are pretty silly from an ivory tower purist view, and are also a pain >>>in practice. I'm with Terry on this one. >> >>If there is such a symbol on 2.1.0 or later I'll use it. > >In the FreeBSD CVS tree, if_de.c is very different in 2.1.x, 2.2.x and 3.0. >Discussions so far imply that you (Matt) intend that your version of if_de.c >should run on all FreeBSD releases. In practice, the code is tweaked for >changing local conditions (ie local to a branch), including mods for stuff >like devconf (deceased) and XNS. I run both 2.1-stable and 2.2-stable so I intend it on both of those (ifdefs and all). Eventually when I get a machine running 3.0 I add the 3.0 changes. >So, I don't think it is a matter of supplying you with a symbol to examine. >The real question is whether or not all FreeBSD branches should be (nearly) >identical (and therefore #ifdef festooned), or whether they should be quite >different, but cleaner. Your call but I'm going to keep the ifdef's. Until there's a clean way of determining 3.0 independent of the compiler, I'm not adding 3.0 ifdef's. -- Matt Thomas Internet: matt@3am-software.com 3am Software Foundry WWW URL: http://www.3am-software.com/bio/matt/ Nashua, NH Disclaimer: I disavow all knowledge of this message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199801291434.JAA19360>