Date: Tue, 16 Jul 2002 22:21:47 -0400 From: W Gerald Hicks <gehicks@gehicks.dyndns.org> To: Bruce Evans <bde@zeta.org.au> Cc: Dikshie <dikshie@ppk.itb.ac.id>, <current@FreeBSD.ORG> Subject: Re: /usr/src/dev/md error (?) Message-ID: <F1D80E50-992B-11D6-99DB-0030657B5F1E@gehicks.dyndns.org> In-Reply-To: <20020717115641.T3327-100000@gamplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday, July 16, 2002, at 10:13 PM, Bruce Evans wrote:
> On Tue, 16 Jul 2002, W Gerald Hicks wrote:
>
>> Following patch should silence it.
>> ...
>> Index: src/sys/dev/md/md.c
>> ===================================================================
>> RCS file: /home/ncvs/src/sys/dev/md/md.c,v
>> retrieving revision 1.66
>> diff -u -r1.66 md.c
>> --- src/sys/dev/md/md.c 24 Jun 2002 12:07:02 -0000 1.66
>> +++ src/sys/dev/md/md.c 16 Jul 2002 21:32:44 -0000
>> @@ -606,6 +606,7 @@
>> error = mdstart_swap(sc, bp);
>> break;
>> default:
>> + error = -1;
>> panic("Impossible md(type)");
>> break;
>> }
>
> This change and the break after the panic() are bogus. panic() "never"
> returns, and the compiler knows this. Unfortunately, the
> RESTARTABLE_PANICS
> option subverts the semantics of panic(), so panic() sometimes returns.
> This breaks compilation of md.c and 28 other files in NOTES. The fix
> shouldn't be to disturb the usual flow of control in those 29 files.
>
> Bruce
>
Ouch. My naive assumption was that panic() really did the deed.
Agree, my suggestion is bogus.
Thanks,
Jerry Hicks
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F1D80E50-992B-11D6-99DB-0030657B5F1E>