Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 6 May 2019 09:27:39 -0600
From:      Alan Somers <asomers@freebsd.org>
Cc:        src-committers <src-committers@freebsd.org>, svn-src-projects@freebsd.org
Subject:   Re: svn commit: r347184 - projects/fuse2/sys/fs/fuse
Message-ID:  <CAOtMX2j5Ydhz12XwrTK44Xo0b69SHoCj8=iRKpW8ZUJQ7Rgnfw@mail.gmail.com>
In-Reply-To: <201905061520.x46FKIUH077726@repo.freebsd.org>
References:  <201905061520.x46FKIUH077726@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, May 6, 2019 at 9:20 AM Alan Somers <asomers@freebsd.org> wrote:
>
> Author: asomers
> Date: Mon May  6 15:20:18 2019
> New Revision: 347184
> URL: https://svnweb.freebsd.org/changeset/base/347184
>
> Log:
>   fusefs: don't allow truncating irregular files on an read-only mount
>
>   The readonly mount check had a special case allowing the sizes of files to
>   be changed if they weren't regular files.  I don't know why.  Neither UFS,
>   ZFS, nor ext2 have such a special case, and I don't know when you would ever
>   change the size of a non-regular file anyway.
>
>   Sponsored by: The FreeBSD Foundation
>
> Modified:
>   projects/fuse2/sys/fs/fuse/fuse_vnops.c

Err, this commit was totally wrong.  I misread the UFS code.  However,
I'm not going to revert it because I'm about to rewrite the affected
function anyway.
-Alan



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAOtMX2j5Ydhz12XwrTK44Xo0b69SHoCj8=iRKpW8ZUJQ7Rgnfw>