Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 13 Feb 2021 21:22:34 +0100 (CET)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        =?ISO-8859-15?Q?Fernando_Apestegu=EDa?= <fernape@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r564769 - head/irc/undernet-ircu
Message-ID:  <44f4698a-4cfd-6a6-6b89-4a4babfdab80@pfeifer.com>
In-Reply-To: <202102090704.11974rlH001767@repo.freebsd.org>
References:  <202102090704.11974rlH001767@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 9 Feb 2021, Fernando Apesteguía wrote:
> -PORTVERSION=	2.10.12.18
> +PORTVERSION=	2.10.12.19

I am curious...

> +USE_GCC=	any

...where does USE_GCC come from for such a minor version update?

Are you sure it even works with the 14 year old version of GCC
used by some (older) versions on some (tier 2) platforms?

If GCC is required, I suggest USE_GCC=yes.

Mk/bsd.gcc.mk tries to describe this a bit, and I'm happy to
enhance it if you have any questions or suggestions.

Thanks,
Gerald
From owner-svn-ports-head@freebsd.org  Sat Feb 13 21:12:23 2021
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9804C53B55C;
 Sat, 13 Feb 2021 21:12:23 +0000 (UTC)
 (envelope-from adridg@FreeBSD.org)
Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org
 [IPv6:2610:1c1:1:606c::19:3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4DdNNl3z3xz3Kwm;
 Sat, 13 Feb 2021 21:12:23 +0000 (UTC)
 (envelope-from adridg@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 7BC1B1E054;
 Sat, 13 Feb 2021 21:12:23 +0000 (UTC)
 (envelope-from adridg@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 11DLCNOa069408;
 Sat, 13 Feb 2021 21:12:23 GMT (envelope-from adridg@FreeBSD.org)
Received: (from adridg@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id 11DLCNtK069407;
 Sat, 13 Feb 2021 21:12:23 GMT (envelope-from adridg@FreeBSD.org)
Message-Id: <202102132112.11DLCNtK069407@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: adridg set sender to
 adridg@FreeBSD.org using -f
From: Adriaan de Groot <adridg@FreeBSD.org>
Date: Sat, 13 Feb 2021 21:12:23 +0000 (UTC)
To: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: svn commit: r565178 - head/Mk/Uses
X-SVN-Group: ports-head
X-SVN-Commit-Author: adridg
X-SVN-Commit-Paths: head/Mk/Uses
X-SVN-Commit-Revision: 565178
X-SVN-Commit-Repository: ports
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.34
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>;
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 13 Feb 2021 21:12:23 -0000

Author: adridg
Date: Sat Feb 13 21:12:23 2021
New Revision: 565178
URL: https://svnweb.freebsd.org/changeset/ports/565178

Log:
  Add KDE_INVENT convenience for KDE ports
  
  KDE has its own GitLab instance. This behaves slightly different
  from other GitLab -- there's not really a "GL_ACCOUNT" involved,
  although the repositories are filed under various categories
  that behave like accounts do on GitLab.com.
  
  Some -- not many -- ports of KDE software pick up unreleased
  software, or software in-between releases. Those tend to use
  the GitHub mirror. That mirror should not be considered a good
  source for the software; it's better to stick close to the real source.
  
  With KDE_INVENT it is immediately clear that a port comes from KDE
  sources, but not released work. It is a shortcut for setting GL_
  values for site, account (category) etc. While there's only a handful
  of ports now that would need it (and we would prefer to **not**
  package unreleased software) the "signal value" is a good one.
  
  Reviewed by:	tcberner

Modified:
  head/Mk/Uses/kde.mk

Modified: head/Mk/Uses/kde.mk
==============================================================================
--- head/Mk/Uses/kde.mk	Sat Feb 13 20:13:20 2021	(r565177)
+++ head/Mk/Uses/kde.mk	Sat Feb 13 21:12:23 2021	(r565178)
@@ -25,6 +25,24 @@
 #		this will then set default values for MASTER_SITES and DIST_SUBDIR
 #		as well as CPE_VENDOR and LICENSE.
 #
+# KDE_INVENT	If the port does not have a regular release, and should
+#		be fetched from KDE Invent (a GitLab instance) it can set
+#		KDE_INVENT to 3 space-separated values:
+#		* a full 40-character commit hash
+#		* a category name inside KDE Invent
+#		* a repository name inside KDE Invent
+#		Default values for category and name are:
+#		* the first item in CATEGORIES that is not "kde"; this
+#		  is useful when the FreeBSD ports category and the KDE
+#		  category are the same (which happens sometimes)
+#		* PORTNAME, often the FreeBSD port name is the same
+#		  as the upstream name and it will not need to be specified.
+#		Sometimes `KDE_INVENT=<hash>` will do and often
+#		`KDE_INVENT=<hash> <category>` is enough.
+#
+#		Setting KDE_INVENT is the equivalent of a handful of USE_GITLAB
+#		and related settings.
+#
 # MAINTAINER:	kde@FreeBSD.org
 
 .if !defined(_INCLUDE_USES_KDE_MK)
@@ -91,6 +109,32 @@ IGNORE?=	cannot be installed: multiple kde-<...> categ
 .        endif
 .      endif
 .    endfor
+
+# Doing source-selection if the sources are on KDE invent
+.    if defined(KDE_INVENT)
+_invent_hash=		${KDE_INVENT:[1]}
+_invent_category=	${KDE_INVENT:[2]}
+_invent_name=		${KDE_INVENT:[3]}
+
+# Fill in default values if bits are missing
+.      if empty(_invent_category)
+_invent_category=	${CATEGORIES:Nkde:[1]}
+.      endif
+.      if empty(_invent_name)
+_invent_name=		${PORTNAME}
+.      endif
+
+# If valid, use it for GitLab
+.      if empty(_invent_hash) || empty(_invent_category) || empty(_invent_name)
+IGNORE?=		invalid KDE_INVENT value '${KDE_INVENT}'
+.      else
+USE_GITLAB=		yes
+GL_SITE=		https://invent.kde.org
+GL_ACCOUNT=		${_invent_category}
+GL_PROJECT=		${_invent_name}
+GL_COMMIT=		${_invent_hash}
+.      endif
+.    endif
 
 .    if defined(_KDE_CATEGORY)
 # KDE is normally licensed under the LGPL 2.0.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?44f4698a-4cfd-6a6-6b89-4a4babfdab80>