Date: Mon, 5 Jun 1995 19:30:29 -0700 (PDT) From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com> To: bde@zeta.org.au (Bruce Evans) Cc: steve2@genesis.tiac.net, hackers@freebsd.org Subject: Re: kernel page fault while doing tar to /dev/rft0 Message-ID: <199506060230.TAA25146@gndrsh.aac.dev.com> In-Reply-To: <199506060206.MAA19355@godzilla.zeta.org.au> from "Bruce Evans" at Jun 6, 95 12:06:46 pm
next in thread | previous in thread | raw e-mail | index | archive | help
>
> >> #endif
> >> + fdblk = 128 << (fd->ft->secsize);
> >> +
>
> >Still will crash some ones system if they get to here with out a
> >ft device since ft will be null!! Now maybe the open code stops
> >them from getting here, I am not sure :-(.
>
> >> if (!(bp->b_flags & B_FORMAT)) {
> >> if ((fdu >= NFD) || (bp->b_blkno < 0)) {
> >> printf(
> >>
>
> >How come fdblk size is coming from the ft structure, but is used in
> >non ft code??? See line 1108, 1118, and 1120. Perhaps the real bug
>
> ft is a pointer to the floppy t_y_pe structure.
Ah.. okay, suggest we rename it to type then! fd->type->secsize makes
a lot more since when reading this code!!!
> >Fails my visial, this patch has been rejected for inclusion at this
> >point in time :-(.
>
> Patches should be reviewed by someone (if any :-) who is familiar with
> the code.
Agreed, but it still fails on the fact the hunk is offset which means
the purson is not testing against -current code.
--
Rod Grimes rgrimes@gndrsh.aac.dev.com
Accurate Automation Company Custom computers for FreeBSD
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199506060230.TAA25146>