Date: Mon, 8 Jan 2018 13:09:42 -0800 From: Conrad Meyer <cem@freebsd.org> To: Pedro Giffuni <pfg@freebsd.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r327699 - head/sys/sys Message-ID: <CAG6CVpWb8YM8MRARiPhPoGim5Vawat8Q2hVgMNR9-zEvGrODgQ@mail.gmail.com> In-Reply-To: <89964e3f-a982-f0e5-a7ff-9c13a5ebe61c@FreeBSD.org> References: <201801081609.w08G9941022351@pdx.rh.CN85.dnsmgr.net> <c6cfb6ae-3be7-db5a-bc2e-bf79d558e338@FreeBSD.org> <CAG6CVpWKWtap3g0rU49NqctKy7Q0d9CR8eS9pNfqxtUXwvvwqQ@mail.gmail.com> <89964e3f-a982-f0e5-a7ff-9c13a5ebe61c@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jan 8, 2018 at 12:54 PM, Pedro Giffuni <pfg@freebsd.org> wrote: > Yeah, I understand where that comes from and I will take it into account = for > future commits, but I think it should be *documented* and not assume that > everybody thinks that is the way version control is supposed to be used. If you want to document it somewhere, I don't think anyone will stop you. In general, we do have a bunch of unwritten guidelines that are either inferred from reading SVN log / source or explicitly requested via review (pre- or post-commit). I don't think it would hurt to document. I don't know if this specific topic is really a FreeBSD guideline or not, but it's a good practice when using any version control system. (You could do the same thing with 'git revert' =E2=80=94 make additions on = top of the revert commit =E2=80=94 and it would be equally a bad practice with that tool.) The only downsides I see are: 0. No one is interested in spending time writing this down and dealing with the inevitable bikeshedding, 1. Consensus may shift over time, and 2. People don't want to spend a ton of time reading rules Best, Conrad
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAG6CVpWb8YM8MRARiPhPoGim5Vawat8Q2hVgMNR9-zEvGrODgQ>