Date: Tue, 19 Nov 2013 05:29:24 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: gjb@FreeBSD.org Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r258310 - head/release Message-ID: <20131119.052924.2179352866091983302.hrs@allbsd.org> In-Reply-To: <20131118195506.GT1643@glenbarber.us> References: <201311181625.rAIGPuRG078815@svn.freebsd.org> <20131119.034852.1148136397426813684.hrs@allbsd.org> <20131118195506.GT1643@glenbarber.us>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Tue_Nov_19_05_29_24_2013_048)--
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Glen Barber <gjb@FreeBSD.org> wrote
in <20131118195506.GT1643@glenbarber.us>:
gj> > gj> -export PKG_ABI="freebsd:$(echo ${REVISION} | tr -d '.0'):x86:64"
gj> > gj> +export PKG_ABI="freebsd:$(echo ${REVISION} | sed -e 's/\.[0-9]//'):x86:64"
gj> >
gj> > PKG_ABI=freebsd:${REVISION%.[0-9]*}:x86:64 is simpler than invoking
gj> > tr or sed. However, pkg-stage.sh should have a mapping rule from
gj> > TARGET and TARGET_ARCH, not in arch specific config files, I think.
gj> > Other than the package list, variables are not arch-specific.
gj> >
gj> The pkg(8) ABI does not map directly to anything we use ('amd64' or
gj> 'i386') unfortunately.
Yes, it is true that it does not map TARGET/TARGET_ARCH directly.
What I mean is that it can be easily translated in pkg-stage.sh by
adding a mapping rule there like this:
case ${TARGET}:{TARGET_ARCH} in
amd64:*) PKG_ABI=x86:64 ;;
...
esac
Depending files in arch-specific directory makes maintenance
difficult when the number of archs and combinations of
TARGET/TARGET_ARCH increase. It can happen when arm and mips are
handled in make release and the package server. Eliminating/reducing
manually-configured variables which can be derived from other ones is
always a good practice.
gj> > Does this guarantee that the packages downloaded by pkg(8) are for a
gj> > specific release? And I think fetching packages can be done just
gj> > after svn co stage in release.sh. Collecting up necessity of network
gj> > access (including fetching distfiles for docproj) before entering the
gj> > chroot environment makes redoing the release build easier.
gj> >
gj>
gj> I don't think it has been discussed yet where packages built for
gj> a specific release will exist. Anyway, I would like to avoid directory
gj> hierarchy pollution outside of the dvd/ directory, this is why I use it
gj> for PKG_CACHEDIR directly.
So I think it should be discussed and we should make the script to
consistently fetch the package set built from the release branch (or
head for stable or snapshots) in the ports tree. While I guess the
current one simply fetches the latest packages, the release iso
images must have packages which correspond to ports.txz.
-- Hiroki
----Security_Multipart(Tue_Nov_19_05_29_24_2013_048)--
Content-Type: application/pgp-signature
Content-Transfer-Encoding: 7bit
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.13 (FreeBSD)
iEYEABECAAYFAlKKeKQACgkQTyzT2CeTzy3gPgCgmdpEiKdLKONFFlVmHhTgdynD
Q5kAniwclnQUjGn7b1Vx7NFbVhkmAd37
=dWpu
-----END PGP SIGNATURE-----
----Security_Multipart(Tue_Nov_19_05_29_24_2013_048)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20131119.052924.2179352866091983302.hrs>